Commit 9ab5c8b6 authored by Marcin Spiewak's avatar Marcin Spiewak Committed by Konrad Sztyber
Browse files

lvol_ut: add test for invalid options 



Add unit test for calling spdk_lvs_load_ext()/lvs_load()
with invalid options (opts_size is 0).

Change-Id: I9c48b972066cf977304e3efa936827d1ef1b5250
Signed-off-by: default avatarMarcin Spiewak <marcin.spiewak@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17584


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarMike Gerdts <mgerdts@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 324e3261

test/unit/lib/lvol/lvol.c/lvol_ut.c

+10 −0
Original line number Diff line number Diff line
@@ -1115,6 +1115,7 @@ test_lvs_load(void) 
	struct spdk_lvs_with_handle_req *req;

	struct spdk_bs_opts bs_opts = {};

	struct spdk_blob *super_blob;

	struct spdk_lvs_opts opts = {};



	req = calloc(1, sizeof(*req));

	SPDK_CU_ASSERT_FATAL(req != NULL);
@@ -1179,6 +1180,15 @@ test_lvs_load(void) 
	CU_ASSERT(g_lvol_store == NULL);

	CU_ASSERT(TAILQ_EMPTY(&g_lvol_stores));



	/* Fail on invalid options */

	g_lvserrno = -1;

	spdk_lvs_opts_init(&opts);

	opts.opts_size = 0; /* Invalid length */

	spdk_lvs_load_ext(&dev.bs_dev, &opts, lvol_store_op_with_handle_complete, NULL);

	CU_ASSERT(g_lvserrno == -EINVAL);

	CU_ASSERT(g_lvol_store == NULL);

	CU_ASSERT(TAILQ_EMPTY(&g_lvol_stores));



	/* Load successfully */

	g_lvserrno = 0;

	super_blob->close_status = 0;