Commit 98ceddb4 authored Nov 17, 2022 by Jim Harris Committed by Tomasz Zawadzki Nov 23, 2022

rocksdb: remove spdk_thread



This was an accidental remnant from the original
check-in, when we did not have a clear differentiation
between the event and thread libraries.

The rocksdb plugin code will send events to an
lcore - not an SPDK thread.  But originally the two
were combined though an API called spdk_allocate_thread.
Once the differentiation was clearly made, we moved to
using spdk_event_allocate() to send events to a specific
lcore, but never removed the spdk_thread.

So now let's just remove the spdk_thread_create since
it is not needed.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I5c6a3c304b7b4183eee90038367fdea7ebd7280f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15504


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>

parent 0d3b5482

lib/rocksdb/env_spdk.cc

+0 −8

Original line number	Diff line number	Diff line
		@@ -59,11 +59,7 @@ thread_local SpdkThreadCtx g_sync_args;
		static void
		set_channel()
		{
		struct spdk_thread *thread;

		if (g_fs != NULL && g_sync_args.channel == NULL) {
		thread = spdk_thread_create("spdk_rocksdb", NULL);
		spdk_set_thread(thread);
		g_sync_args.channel = spdk_fs_alloc_thread_ctx(g_fs);
		}
		}
		@@ -610,14 +606,10 @@ public:
		*/
		void SpdkInitializeThread(void)
		{
		struct spdk_thread *thread;

		if (g_fs != NULL) {
		if (g_sync_args.channel) {
		spdk_fs_free_thread_ctx(g_sync_args.channel);
		}
		thread = spdk_thread_create("spdk_rocksdb", NULL);
		spdk_set_thread(thread);
		g_sync_args.channel = spdk_fs_alloc_thread_ctx(g_fs);
		}
		}