Commit 98c63be8 authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Jim Harris
Browse files

test: Shellcheck - include check SC2121 



Remove from shellcheck excluded SC2121: To assign a variable,
use just 'var=value', no 'set ..'.
This warning is not actually present in any of spdk/spdk scripts.

Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: I7dae1d73f0e276ef9e5a0cfa78a56227264c0a4d
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473272


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 9a4a87b5

scripts/check_format.sh

+3 −2
Original line number Diff line number Diff line
@@ -242,8 +242,9 @@ if hash shellcheck 2>/dev/null; then 
	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1083,SC2002,\

SC2010,SC2012,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\

SC2097,SC2098,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\

SC2129,SC2140,SC2142,SC2143,SC2154,SC2155,SC2162"

SC2097,SC2098,SC2119,SC2120,SC2124,SC2126,SC2128,\

SC2129,SC2140,SC2142,SC2143,SC2154,SC2155,\

SC2162"

	# SPDK fails some error checks which have been deprecated in later versions of shellcheck.

	# We will not try to fix these error checks, but instead just leave the error types here

	# so that we can still run with older versions of shellcheck.