Commit 988af676 authored May 02, 2021 by Ziye Yang Committed by Tomasz Zawadzki May 05, 2021

nvmf/tcp: Remove the unnecessary qpair setting.



It is already set by nvmf_tcp_req_pdu_init
when we get the pdu. So we do not set it again.

Change-Id: I034bbc46e600afd802457c0b152e303f16bafba3
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7714


Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

parent d97b106f

lib/nvmf/tcp.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -901,7 +901,6 @@ nvmf_tcp_qpair_write_pdu(struct spdk_nvmf_tcp_qpair *tqpair,
		hlen = pdu->hdr.common.hlen;
		pdu->cb_fn = cb_fn;
		pdu->cb_arg = cb_arg;
		pdu->qpair = tqpair;

		pdu->iov[0].iov_base = &pdu->hdr.raw;
		pdu->iov[0].iov_len = hlen;

test/unit/lib/nvmf/tcp.c/tcp_ut.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -559,6 +559,7 @@ test_nvmf_tcp_send_c2h_data(void)

		tcp_req.pdu = &pdu;
		tcp_req.req.length = 300;
		tcp_req.req.qpair = &tqpair.qpair;

		tqpair.qpair.transport = &ttransport.transport;