Commit 9796c6cd authored by Jim Harris's avatar Jim Harris
Browse files

nvmf/tcp: remove FLUSH_WRITEBUF events 



These seem to have been copied from iSCSI code, but they were never actually
used, so remove them.

Upcoming patches will be adding the same functionality anyways, via sock
layer events.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I1bc1f772229d8f2c8ea5799d895972e81177d300
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22105


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarSeung yeon Shin <syeon.shin@samsung.com>
Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent f30fdcf1

include/spdk_internal/trace_defs.h

+0 −2
Original line number Diff line number Diff line
@@ -66,8 +66,6 @@ 
#define TRACE_TCP_REQUEST_STATE_TRANSFERRING_CONTROLLER_TO_HOST	SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x0a)

#define TRACE_TCP_REQUEST_STATE_AWAIT_ZCOPY_RELEASE		SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x0b)

#define TRACE_TCP_REQUEST_STATE_COMPLETED			SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x0c)

#define TRACE_TCP_FLUSH_WRITEBUF_START				SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x0d)

#define TRACE_TCP_FLUSH_WRITEBUF_DONE				SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x0e)

#define TRACE_TCP_READ_FROM_SOCKET_DONE				SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x0f)

#define TRACE_TCP_REQUEST_STATE_AWAIT_R2T_ACK			SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x10)

#define TRACE_TCP_QP_CREATE					SPDK_TPOINT_ID(TRACE_GROUP_NVMF_TCP, 0x11)

lib/nvmf/tcp.c

+0 −8
Original line number Diff line number Diff line
@@ -169,14 +169,6 @@ SPDK_TRACE_REGISTER_FN(nvmf_tcp_trace, "nvmf_tcp", TRACE_GROUP_NVMF_TCP) 
					TRACE_TCP_REQUEST_STATE_COMPLETED,

					OWNER_NVMF_TCP, OBJECT_NVMF_TCP_IO, 0,

					SPDK_TRACE_ARG_TYPE_PTR, "qpair");

	spdk_trace_register_description("TCP_WRITE_START",

					TRACE_TCP_FLUSH_WRITEBUF_START,

					OWNER_NVMF_TCP, OBJECT_NONE, 0,

					SPDK_TRACE_ARG_TYPE_PTR, "qpair");

	spdk_trace_register_description("TCP_WRITE_DONE",

					TRACE_TCP_FLUSH_WRITEBUF_DONE,

					OWNER_NVMF_TCP, OBJECT_NONE, 0,

					SPDK_TRACE_ARG_TYPE_PTR, "qpair");

	spdk_trace_register_description("TCP_READ_DONE",

					TRACE_TCP_READ_FROM_SOCKET_DONE,

					OWNER_NVMF_TCP, OBJECT_NONE, 0,