Commit 97934c52 authored by Tomasz Zawadzki's avatar Tomasz Zawadzki Committed by Daniel Verkamp
Browse files

lvol: add snapshots and clones 



Signed-off-by: default avatarPiotr Pelplinski <piotr.pelplinski@intel.com>
Signed-off-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Signed-off-by: default avatarTomasz Kulasek <tomaszx.kulasek@intel.com>
Change-Id: Ibc43e3ee65d85a83d78d6e15457ae57992a1188a
Reviewed-on: https://review.gerrithub.io/395059


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
parent 38d75b56

include/spdk/lvol.h

+20 −0
Original line number Diff line number Diff line
@@ -161,6 +161,26 @@ int spdk_lvs_destroy(struct spdk_lvol_store *lvol_store, 
 */

int spdk_lvol_create(struct spdk_lvol_store *lvs, const char *name, uint64_t sz,

		     bool thin_provisioned, spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg);

/**

 * \brief Create snapshot of given lvol

 * \param lvol Handle to lvol

 * \param snapshot_name Name of created snapshot

 * \param cb_fn Completion callback

 * \param cb_arg Completion callback custom arguments

 */

void spdk_lvol_create_snapshot(struct spdk_lvol *lvol, const char *snapshot_name,

			       spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg);



/**

 * \brief Create clone of given snapshot

 * \param lvol Handle to lvol snapshot

 * \param clone_name Name of created clone

 * \param cb_fn Completion callback

 * \param cb_arg Completion callback custom arguments

 */

void spdk_lvol_create_clone(struct spdk_lvol *lvol, const char *clone_name,

			    spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg);





/**

 * \brief Renames lvol with new_name.

include/spdk_internal/bdev.h

+1 −1
Original line number Diff line number Diff line
@@ -448,7 +448,7 @@ struct spdk_bdev_io { 


int spdk_bdev_register(struct spdk_bdev *bdev);

void spdk_bdev_unregister(struct spdk_bdev *bdev, spdk_bdev_unregister_cb cb_fn, void *cb_arg);

void spdk_bdev_unregister_done(struct spdk_bdev *bdev, int bdeverrno);

void spdk_bdev_destruct_done(struct spdk_bdev *bdev, int bdeverrno);

int spdk_vbdev_register(struct spdk_bdev *vbdev, struct spdk_bdev **base_bdevs,

			int base_bdev_count);

lib/bdev/bdev.c

+1 −1
Original line number Diff line number Diff line
@@ -2648,7 +2648,7 @@ spdk_vbdev_register(struct spdk_bdev *vbdev, struct spdk_bdev **base_bdevs, int 
}



void

spdk_bdev_unregister_done(struct spdk_bdev *bdev, int bdeverrno)

spdk_bdev_destruct_done(struct spdk_bdev *bdev, int bdeverrno)

{

	if (bdev->unregister_cb != NULL) {

		bdev->unregister_cb(bdev->unregister_ctx, bdeverrno);

lib/bdev/lvol/vbdev_lvol.c

+46 −4
Original line number Diff line number Diff line
@@ -523,9 +523,13 @@ _vbdev_lvol_destroy_cb(void *cb_arg, int lvserrno) 
{

	struct spdk_bdev *bdev = cb_arg;



	if (lvserrno == -EBUSY) {

		/* TODO: Handle reporting error to spdk_bdev_unregister */

	}



	SPDK_INFOLOG(SPDK_LOG_VBDEV_LVOL, "Lvol destroyed\n");



	spdk_bdev_unregister_done(bdev, lvserrno);

	spdk_bdev_destruct_done(bdev, lvserrno);

	free(bdev->name);

	free(bdev);

}
@@ -538,7 +542,7 @@ _vbdev_lvol_destroy_after_close_cb(void *cb_arg, int lvserrno) 


	if (lvserrno != 0) {

		SPDK_INFOLOG(SPDK_LOG_VBDEV_LVOL, "Could not close Lvol %s\n", lvol->unique_id);

		spdk_bdev_unregister_done(bdev, lvserrno);

		spdk_bdev_destruct_done(bdev, lvserrno);

		free(bdev->name);

		free(bdev);

		return;
@@ -619,11 +623,13 @@ static bool 
vbdev_lvol_io_type_supported(void *ctx, enum spdk_bdev_io_type io_type)

{

	switch (io_type) {

	case SPDK_BDEV_IO_TYPE_READ:

	case SPDK_BDEV_IO_TYPE_WRITE:

	case SPDK_BDEV_IO_TYPE_RESET:

	case SPDK_BDEV_IO_TYPE_UNMAP:

	case SPDK_BDEV_IO_TYPE_WRITE_ZEROES:

		/* TODO: Report false if snapshot */

		return true;

	case SPDK_BDEV_IO_TYPE_RESET:

	case SPDK_BDEV_IO_TYPE_READ:

		return true;

	default:

		return false;
@@ -887,6 +893,42 @@ vbdev_lvol_create(struct spdk_lvol_store *lvs, const char *name, size_t sz, 
	return rc;

}



void

vbdev_lvol_create_snapshot(struct spdk_lvol *lvol, const char *snapshot_name,

			   spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg)

{

	struct spdk_lvol_with_handle_req *req;



	req = calloc(1, sizeof(*req));

	if (req == NULL) {

		cb_fn(cb_arg, NULL, -ENOMEM);

		return;

	}



	req->cb_fn = cb_fn;

	req->cb_arg = cb_arg;



	spdk_lvol_create_snapshot(lvol, snapshot_name, _vbdev_lvol_create_cb, req);

}



void

vbdev_lvol_create_clone(struct spdk_lvol *lvol, const char *clone_name,

			spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg)

{

	struct spdk_lvol_with_handle_req *req;



	req = calloc(1, sizeof(*req));

	if (req == NULL) {

		cb_fn(cb_arg, NULL, -ENOMEM);

		return;

	}



	req->cb_fn = cb_fn;

	req->cb_arg = cb_arg;



	spdk_lvol_create_clone(lvol, clone_name, _vbdev_lvol_create_cb, req);

}



static void

_vbdev_lvol_rename_cb(void *cb_arg, int lvolerrno)

{

lib/bdev/lvol/vbdev_lvol.h

+6 −0
Original line number Diff line number Diff line
@@ -55,6 +55,12 @@ void vbdev_lvs_unload(struct spdk_lvol_store *lvs, spdk_lvs_op_complete cb_fn, v 
int vbdev_lvol_create(struct spdk_lvol_store *lvs, const char *name, size_t sz,

		      bool thin_provisioned, spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg);



void vbdev_lvol_create_snapshot(struct spdk_lvol *lvol, const char *snapshot_name,

				spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg);



void vbdev_lvol_create_clone(struct spdk_lvol *lvol, const char *clone_name,

			     spdk_lvol_op_with_handle_complete cb_fn, void *cb_arg);



int vbdev_lvol_resize(char *name, size_t sz, spdk_lvol_op_complete cb_fn, void *cb_arg);



void vbdev_lvol_rename(struct spdk_lvol *lvol, const char *new_lvol_name,