Commit 9674a7b6 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Darek Stojaczyk
Browse files

bdev/ftl: better config errors logging 



Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Ie3814a905efa6122d56a5f2dfc9710d016e8449e
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448713


Reviewed-by: default avatarDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: default avatarWojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 3c4199d6

lib/bdev/nvme/bdev_ftl.c

+9 −10
Original line number Diff line number Diff line
@@ -485,27 +485,26 @@ bdev_ftl_read_bdev_config(struct spdk_conf_section *sp, 
			  struct ftl_bdev_init_opts *opts,

			  size_t *num_bdevs)

{

	const char *val;

	size_t i;

	int rc = 0;

	const char *val, *trid;

	int i, rc = 0;



	*num_bdevs = 0;



	for (i = 0; i < FTL_MAX_BDEVS; i++, opts++) {

		val = spdk_conf_section_get_nmval(sp, "TransportID", i, 0);

		trid = val = spdk_conf_section_get_nmval(sp, "TransportID", i, 0);

		if (!val) {

			break;

		}



		rc = spdk_nvme_transport_id_parse(&opts->trid, val);

		if (rc < 0) {

			SPDK_ERRLOG("Unable to parse TransportID: %s\n", val);

			SPDK_ERRLOG("Unable to parse TransportID: %s\n", trid);

			rc = -1;

			break;

		}



		if (opts->trid.trtype != SPDK_NVME_TRANSPORT_PCIE) {

			SPDK_ERRLOG("Unsupported transport type\n");

			SPDK_ERRLOG("Unsupported transport type for TransportID: %s\n", trid);

			continue;

		}
@@ -513,7 +512,7 @@ bdev_ftl_read_bdev_config(struct spdk_conf_section *sp, 


		val = spdk_conf_section_get_nmval(sp, "TransportID", i, 1);

		if (!val) {

			SPDK_ERRLOG("No name provided for TransportID\n");

			SPDK_ERRLOG("No name provided for TransportID: %s\n", trid);

			rc = -1;

			break;

		}
@@ -521,13 +520,13 @@ bdev_ftl_read_bdev_config(struct spdk_conf_section *sp, 


		val = spdk_conf_section_get_nmval(sp, "TransportID", i, 2);

		if (!val) {

			SPDK_ERRLOG("No punit range provided for TransportID\n");

			SPDK_ERRLOG("No punit range provided for TransportID: %s\n", trid);

			rc = -1;

			break;

		}



		if (bdev_ftl_parse_punits(&opts->range, val)) {

			SPDK_ERRLOG("Invalid punit range\n");

			SPDK_ERRLOG("Invalid punit range for TransportID: %s\n", trid);

			rc = -1;

			break;

		}
@@ -539,7 +538,7 @@ bdev_ftl_read_bdev_config(struct spdk_conf_section *sp, 


		rc = spdk_uuid_parse(&opts->uuid, val);

		if (rc < 0) {

			SPDK_ERRLOG("Failed to parse uuid: %s\n", val);

			SPDK_ERRLOG("Failed to parse uuid: %s for TransportID: %s\n", val, trid);

			rc = -1;

			break;

		}