Commit 96474e9e authored by Kamil Godzwon's avatar Kamil Godzwon Committed by Tomasz Zawadzki
Browse files

scripts/nvmf_perf: use a more pythonic approach for condition checking 



As all of those variables are boolean type we can change
condition checking and drop 'is True/False'.

Signed-off-by: default avatarKamil Godzwon <kamilx.godzwon@intel.com>
Change-Id: I9efae7178be335c25be52f76bb208acb644dc303
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/19746


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-by: default avatarJaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Reviewed-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarKarol Latecki <karol.latecki@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarMarek Chomnicki <marek.chomnicki@intel.com>
parent 2eb1b096

scripts/perf/nvmf/run_nvmf.py

+4 −4
Original line number Diff line number Diff line
@@ -87,7 +87,7 @@ class Server(ABC): 
    def read_config(self, config_fields, config):

        for config_field in config_fields:

            value = config.get(config_field.name, config_field.default)

            if config_field.required is True and value is None:

            if config_field.required and value is None:

                raise ValueError('%s config key is required' % config_field.name)



            setattr(self, config_field.name, value)
@@ -606,7 +606,7 @@ class Target(Server): 
        self.spdk_dir = os.path.abspath(os.path.join(self.script_dir, "../../../"))

        self.set_local_nic_info(self.set_local_nic_info_helper())



        if self.skip_spdk_install is False:

        if not self.skip_spdk_install:

            self.zip_spdk_sources(self.spdk_dir, "/tmp/spdk.zip")



        self.configure_system()
@@ -780,7 +780,7 @@ class Initiator(Server): 
        self.exec_cmd(["mkdir", "-p", "%s" % self.spdk_dir])

        self._nics_json_obj = json.loads(self.exec_cmd(["ip", "-j", "address", "show"]))



        if self.skip_spdk_install is False:

        if not self.skip_spdk_install:

            self.copy_spdk("/tmp/spdk.zip")



        self.set_local_nic_info(self.set_local_nic_info_helper())
@@ -1546,7 +1546,7 @@ class SPDKInitiator(Initiator): 
    def __init__(self, name, general_config, initiator_config):

        super().__init__(name, general_config, initiator_config)



        if self.skip_spdk_install is False:

        if not self.skip_spdk_install:

            self.install_spdk()



        # Optional fields