Commit 9620917a authored by Ziye Yang's avatar Ziye Yang Committed by Daniel Verkamp
Browse files

nvmf: Remove the cmd_type variable. 



When Debug is not defined, SPDK_TRACELOG will do nothing,
thus cmd_type is an unused variable, and will trigger the
compilation warnings. And this patch will solve this issue

Change-Id: I821f7601a16c98e514227aee2e18fbfa61928bea
Signed-off-by: default avatarZiye Yang <ziye.yang@intel.com>
parent 9efe055e

lib/nvmf/request.c

+4 −5
Original line number Diff line number Diff line
@@ -460,19 +460,18 @@ nvmf_trace_command(union nvmf_h2c_msg *h2c_msg, enum conn_type conn_type) 
	struct spdk_nvmf_capsule_cmd *cap_hdr = &h2c_msg->nvmf_cmd;

	struct spdk_nvme_cmd *cmd = &h2c_msg->nvme_cmd;

	struct spdk_nvme_sgl_descriptor *sgl = &cmd->dptr.sgl1;

	const char *cmd_type;

	uint8_t opc;



	cmd_type = conn_type == CONN_TYPE_AQ ? "Admin" : "I/O";



	if (cmd->opc == SPDK_NVME_OPC_FABRIC) {

		opc = cap_hdr->fctype;

		SPDK_TRACELOG(SPDK_TRACE_NVMF, "%s Fabrics cmd: fctype 0x%02x cid %u\n",

			      cmd_type, cap_hdr->fctype, cap_hdr->cid);

			      conn_type == CONN_TYPE_AQ ? "Admin" : "I/O",

			      cap_hdr->fctype, cap_hdr->cid);

	} else {

		opc = cmd->opc;

		SPDK_TRACELOG(SPDK_TRACE_NVMF, "%s cmd: opc 0x%02x fuse %u cid %u nsid %u cdw10 0x%08x\n",

			      cmd_type, cmd->opc, cmd->fuse, cmd->cid, cmd->nsid, cmd->cdw10);

			      conn_type == CONN_TYPE_AQ ? "Admin" : "I/O",

			      cmd->opc, cmd->fuse, cmd->cid, cmd->nsid, cmd->cdw10);

		if (cmd->mptr) {

			SPDK_TRACELOG(SPDK_TRACE_NVMF, "mptr 0x%" PRIx64 "\n", cmd->mptr);

		}