Commit 95bfca6c authored by Maciej Wawryk's avatar Maciej Wawryk Committed by Jim Harris
Browse files

RPC: rename set_log_print_level to log_set_print_level 



Signed-off-by: default avatarMaciej Wawryk <maciejx.wawryk@intel.com>
Change-Id: I6d9a26274a213cbc99c36a4b85edaf02564bc262
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468686


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 793d34e5

doc/jsonrpc.md

+1 −1
Original line number Diff line number Diff line
@@ -253,7 +253,7 @@ Example response: 
    "get_log_level",

    "set_log_level",

    "get_log_print_level",

    "set_log_print_level",

    "log_set_print_level",

    "get_iscsi_global_params",

    "iscsi_target_node_add_lun",

    "iscsi_get_connections",

lib/log_rpc/log_rpc.c

+3 −2
Original line number Diff line number Diff line
@@ -99,7 +99,7 @@ _get_log_level_name(int level) 
}



static void

spdk_rpc_set_log_print_level(struct spdk_jsonrpc_request *request,

spdk_rpc_log_set_print_level(struct spdk_jsonrpc_request *request,

			     const struct spdk_json_val *params)

{

	struct rpc_log_level req = {};
@@ -133,8 +133,9 @@ spdk_rpc_set_log_print_level(struct spdk_jsonrpc_request *request, 
invalid:

	free_rpc_log_level(&req);

}

SPDK_RPC_REGISTER("set_log_print_level", spdk_rpc_set_log_print_level,

SPDK_RPC_REGISTER("log_set_print_level", spdk_rpc_log_set_print_level,

		  SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)

SPDK_RPC_REGISTER_ALIAS_DEPRECATED(log_set_print_level, set_log_print_level)



static void

spdk_rpc_get_log_print_level(struct spdk_jsonrpc_request *request,

scripts/rpc.py

+5 −4
Original line number Diff line number Diff line
@@ -1160,12 +1160,13 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse 
    p = subparsers.add_parser('get_log_level', help='get log level')

    p.set_defaults(func=get_log_level)



    def set_log_print_level(args):

        rpc.log.set_log_print_level(args.client, level=args.level)

    def log_set_print_level(args):

        rpc.log.log_set_print_level(args.client, level=args.level)



    p = subparsers.add_parser('set_log_print_level', help='set log print level')

    p = subparsers.add_parser('log_set_print_level', aliases=['set_log_print_level'],

                              help='set log print level')

    p.add_argument('level', help='log print level we want to set. (for example "DEBUG").')

    p.set_defaults(func=set_log_print_level)

    p.set_defaults(func=log_set_print_level)



    def get_log_print_level(args):

        print_dict(rpc.log.get_log_print_level(args.client))

scripts/rpc/log.py

+3 −2
Original line number Diff line number Diff line
@@ -52,14 +52,15 @@ def get_log_level(client): 
    return client.call('get_log_level')





def set_log_print_level(client, level):

@deprecated_alias('set_log_print_level')

def log_set_print_level(client, level):

    """Set log print level.



    Args:

        level: log print level we want to set. (for example "DEBUG")

    """

    params = {'level': level}

    return client.call('set_log_print_level', params)

    return client.call('log_set_print_level', params)





def get_log_print_level(client):