Commit 9555e045 authored by Jacek Kalwas's avatar Jacek Kalwas Committed by Tomasz Zawadzki
Browse files

nvme/tcp: change nvme_tcp_qpair_write_pdu to return void 



This improves code readability. If required can be restored later.
Most of callers do not check rc anyway.

Change-Id: Ic02afccade47ff05f048314dad5cf9e13152f139
Signed-off-by: default avatarJacek Kalwas <jacek.kalwas@nutanix.com>
Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/26145


Reviewed-by: default avatarKonrad Sztyber <ksztyber@nvidia.com>
Tested-by: default avatarSPDK Automated Test System <spdkbot@gmail.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz@tzawadzki.com>
parent f634e8b0

lib/nvme/nvme_tcp.c

+3 −5
Original line number Diff line number Diff line
@@ -665,7 +665,7 @@ pdu_compute_crc32(struct nvme_tcp_pdu *pdu) 
	tcp_write_pdu(pdu);

}



static int

static void

nvme_tcp_qpair_write_pdu(struct nvme_tcp_qpair *tqpair,

			 struct nvme_tcp_pdu *pdu,

			 nvme_tcp_qpair_xfer_complete_cb cb_fn,
@@ -686,8 +686,6 @@ nvme_tcp_qpair_write_pdu(struct nvme_tcp_qpair *tqpair, 
	}



	pdu_compute_crc32(pdu);



	return 0;

}



static int
@@ -953,8 +951,8 @@ nvme_tcp_qpair_capsule_cmd_send(struct nvme_tcp_qpair *tqpair, 
				  0, tcp_req->req->payload_size);

end:

	capsule_cmd->common.plen = plen;

	return nvme_tcp_qpair_write_pdu(tqpair, pdu, nvme_tcp_qpair_cmd_send_complete, tcp_req);



	nvme_tcp_qpair_write_pdu(tqpair, pdu, nvme_tcp_qpair_cmd_send_complete, tcp_req);

	return 0;

}



static int