Commit 94f2def6 authored by dongx.yi's avatar dongx.yi Committed by Tomasz Zawadzki
Browse files

test/unit: Add nvme_uevent_ut.c to unittest. 



Add nvme_uevent_ut.c to unittest, and test parse uevents.

Signed-off-by: default avatardongx.yi <dongx.yi@intel.com>
Change-Id: Id8bb8336790ae5e031b357dc49163d86dfa1cd57
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475080


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Community-CI: SPDK CI Jenkins <sys_sgci@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent f57842c2

test/unit/lib/nvme/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../..) 
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk



DIRS-y = nvme.c nvme_ctrlr.c nvme_ctrlr_cmd.c nvme_ctrlr_ocssd_cmd.c nvme_ns.c nvme_ns_cmd.c nvme_ns_ocssd_cmd.c nvme_pcie.c nvme_qpair.c \

	 nvme_quirks.c nvme_tcp.c \

	 nvme_quirks.c nvme_tcp.c nvme_uevent.c \



DIRS-$(CONFIG_RDMA) += nvme_rdma.c

test/unit/lib/nvme/nvme_uevent.c/.gitignore

0 → 100644
+1 −0
Original line number Diff line number Diff line 
nvme_uevent_ut

test/unit/lib/nvme/nvme_uevent.c/Makefile

0 → 100644
+38 −0
Original line number Diff line number Diff line 
#

#  BSD LICENSE

#

#  Copyright (c) Intel Corporation.

#  All rights reserved.

#

#  Redistribution and use in source and binary forms, with or without

#  modification, are permitted provided that the following conditions

#  are met:

#

#    * Redistributions of source code must retain the above copyright

#      notice, this list of conditions and the following disclaimer.

#    * Redistributions in binary form must reproduce the above copyright

#      notice, this list of conditions and the following disclaimer in

#      the documentation and/or other materials provided with the

#      distribution.

#    * Neither the name of Intel Corporation nor the names of its

#      contributors may be used to endorse or promote products derived

#      from this software without specific prior written permission.

#

#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

#  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

#  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR

#  A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT

#  OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

#  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

#  LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

#  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

#  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

#  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

#  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#



SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../../..)



TEST_FILE = nvme_uevent_ut.c



include $(SPDK_ROOT_DIR)/mk/spdk.unittest.mk

test/unit/lib/nvme/nvme_uevent.c/nvme_uevent_ut.c

0 → 100644
+176 −0
Original line number Diff line number Diff line 
/*-

 *   BSD LICENSE

 *

 *   Copyright (c) Intel Corporation.

 *   All rights reserved.

 *

 *   Redistribution and use in source and binary forms, with or without

 *   modification, are permitted provided that the following conditions

 *   are met:

 *

 *     * Redistributions of source code must retain the above copyright

 *       notice, this list of conditions and the following disclaimer.

 *     * Redistributions in binary form must reproduce the above copyright

 *       notice, this list of conditions and the following disclaimer in

 *       the documentation and/or other materials provided with the

 *       distribution.

 *     * Neither the name of Intel Corporation nor the names of its

 *       contributors may be used to endorse or promote products derived

 *       from this software without specific prior written permission.

 *

 *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

 *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

 *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR

 *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT

 *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

 *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

 *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

 *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

 *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

 *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

 *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 */



#include "spdk_cunit.h"



#include "spdk/env.h"



#include "common/lib/test_env.c"



#include "nvme/nvme_uevent.c"



#ifdef __linux__



enum uevent_parse_event_return_type {

	uevent_abnormal_exit = -1,

	uevent_normal_exit = 0,

	uevent_expected_continue = 1

};



#define SPDK_NVME_UEVENT_SUBSYSTEM_NULL 0xFF



static void

test_nvme_uevent_parse_event(void)

{

	char *commands;

	struct spdk_uevent uevent = {};

	int rc = uevent_normal_exit;



	/* Simulate commands to check expected behaviors */

	/* Linux kernel puts null characters after every uevent */



	/* Case 1: Add wrong non-uio or vfio-pci /devices/pci0000:80/0000:80:01.0/0000:81:00.0/uio/uio0 */

	commands =

		"ACTION=add\0DEVPATH=/devices/pci0000:80/0000:80:01.0/0000:81:00.0/uio/uio0\0SUBSYSTEM= \0DRIVER= \0PCI_SLOT_NAME= \0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;

	uevent.action = 0;



	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_abnormal_exit);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_NULL);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_ADD);



	/* Case 2: Add uio /devices/pci0000:80/0000:80:01.0/0000:81:00.0/uio/uio0 */

	commands =

		"ACTION=add \0DEVPATH=/devices/pci0000:80/0000:80:01.0/0000:81:00.0/uio/uio0\0SUBSYSTEM=uio\0DRIVER=\0PCI_SLOT_NAME= \0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;

	uevent.action = 0;



	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_expected_continue);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_UIO);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_ADD);



	/* Case 3: Remove uio /devices/pci0000:80/0000:80:01.0/0000:81:00.0/uio/uio0 */

	commands =

		"ACTION=remove\0DEVPATH=/devices/pci0000:80/0000:80:01.0/0000:81:00.0/uio/uio0\0SUBSYSTEM=uio\0DRIVER=\0PCI_SLOT_NAME= \0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;



	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_expected_continue);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_UIO);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_REMOVE);



	/* Case 4: Add vfio-pci 0000:81:00.0 */

	commands = "ACTION=bind\0DEVPATH=\0SUBSYSTEM= \0DRIVER=vfio-pci\0PCI_SLOT_NAME=0000:81:00.0\0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;



	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_expected_continue);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_VFIO);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_ADD);



	/* Case 5: Remove vfio-pci 0000:81:00.0 */

	commands = "ACTION=remove\0DEVPATH= \0SUBSYSTEM= \0DRIVER=vfio-pci \0PCI_SLOT_NAME=0000:81:00.0\0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;



	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_expected_continue);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_VFIO);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_REMOVE);



	/* Case 6: Add wrong vfio-pci addr 000000 */

	commands = "ACTION=bind\0DEVPATH= \0SUBSYSTEM= \0DRIVER=vfio-pci \0PCI_SLOT_NAME=000000\0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;



	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_abnormal_exit);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_VFIO);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_ADD);



	/* Case 7: Add wrong type vfio 0000:81:00.0 */

	commands = "ACTION=bind\0DEVPATH= \0SUBSYSTEM= \0DRIVER=vfio \0PCI_SLOT_NAME=0000:81:00.0\0";

	uevent.subsystem = SPDK_NVME_UEVENT_SUBSYSTEM_NULL;

	uevent.action = 0;

	rc = parse_event(commands, &uevent);



	CU_ASSERT(rc == uevent_abnormal_exit);

	CU_ASSERT(uevent.subsystem == SPDK_NVME_UEVENT_SUBSYSTEM_NULL);

	CU_ASSERT(uevent.action == SPDK_NVME_UEVENT_ADD);

}



#else



static void

test_nvme_uevent_parse_event(void)

{

	CU_ASSERT(1);

}



#endif



int main(int argc, char **argv)

{

	CU_pSuite	suite = NULL;

	unsigned int	num_failures;



	if (CU_initialize_registry() != CUE_SUCCESS) {

		return CU_get_error();

	}



	suite = CU_add_suite("nvme_uevent", NULL, NULL);

	if (suite == NULL) {

		CU_cleanup_registry();

		return CU_get_error();

	}



	if (

		CU_add_test(suite, "test_nvme_uevent_parse_event",

			    test_nvme_uevent_parse_event) == NULL

	) {

		CU_cleanup_registry();

		return CU_get_error();

	}



	CU_basic_set_mode(CU_BRM_VERBOSE);

	CU_basic_run_tests();

	num_failures = CU_get_number_of_failures();

	CU_cleanup_registry();

	return num_failures;

}

test/unit/unittest.sh

+1 −0
Original line number Diff line number Diff line
@@ -78,6 +78,7 @@ function unittest_nvme { 
	$valgrind $testdir/lib/nvme/nvme_pcie.c/nvme_pcie_ut

	$valgrind $testdir/lib/nvme/nvme_quirks.c/nvme_quirks_ut

	$valgrind $testdir/lib/nvme/nvme_tcp.c/nvme_tcp_ut

	$valgrind $testdir/lib/nvme/nvme_uevent.c/nvme_uevent_ut

}



function unittest_nvmf {