Commit 94adbefa authored by Changpeng Liu's avatar Changpeng Liu
Browse files

nvmf/vfio-user: disable shared IO CQ case 



Existing vfio-user assumes that the IO SQ/CQ are paired, so we
return an error when creating SQ with shared CQID.

Leave a TODO comment, we may support this in future.

Change-Id: I297ce53eb9a119469145e2453177d03252b629c8
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9173


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarThanos Makatos <thanos.makatos@nutanix.com>
parent 2bd631dc

lib/nvmf/vfio_user.c

+6 −0
Original line number Diff line number Diff line
@@ -1174,6 +1174,12 @@ handle_create_io_q(struct nvmf_vfio_user_ctrlr *ctrlr, 
			sc = SPDK_NVME_SC_INVALID_CONTROLLER_MEM_BUF;

			goto out;

		}

		/* TODO: support shared IO CQ */

		if (qid != cmd->cdw11_bits.create_io_sq.cqid) {

			SPDK_ERRLOG("%s: doesn't support shared CQ now\n", ctrlr_id(ctrlr));

			sct = SPDK_NVME_SCT_COMMAND_SPECIFIC;

			sc = SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER;

		}



		io_q = &ctrlr->qp[qid]->sq;

		io_q->cqid = cmd->cdw11_bits.create_io_sq.cqid;