Commit 947e85d8 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Konrad Sztyber
Browse files

bdev/nvme: Clean up accel_sequence_supported() to follow existing pattern



Previously, bdev_nvme_get_ctrlr() was used by
bdev_nvme_accel_sequence_supported(). However, bdev_nvme_get_ctrlr() was
for special purpose and was not general. Following the existing
bdev_nvme_io_type_supported() will be better.

Signed-off-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Change-Id: Ib4828c3caa4cf9c9d3bec1fe708d75322b816063
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24909


Community-CI: Mellanox Build Bot
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 3edf9f12
Loading
Loading
Loading
Loading
+5 −1
Original line number Diff line number Diff line
@@ -4248,6 +4248,7 @@ static bool
bdev_nvme_accel_sequence_supported(void *ctx, enum spdk_bdev_io_type type)
{
	struct nvme_bdev *nbdev = ctx;
	struct nvme_ns *nvme_ns;
	struct spdk_nvme_ctrlr *ctrlr;

	if (!g_opts.allow_accel_sequence) {
@@ -4262,7 +4263,10 @@ bdev_nvme_accel_sequence_supported(void *ctx, enum spdk_bdev_io_type type)
		return false;
	}

	ctrlr = bdev_nvme_get_ctrlr(&nbdev->disk);
	nvme_ns = TAILQ_FIRST(&nbdev->nvme_ns_list);
	assert(nvme_ns != NULL);

	ctrlr = nvme_ns->ctrlr->ctrlr;
	assert(ctrlr != NULL);

	return spdk_nvme_ctrlr_get_flags(ctrlr) & SPDK_NVME_CTRLR_ACCEL_SEQUENCE_SUPPORTED;