Commit 9412e600 authored by Daniel Verkamp's avatar Daniel Verkamp
Browse files

nvmf: check spdk_nvmf_tgt_listen() return value 



spdk_nvmf_tgt_listen() can fail due to invalid user input (e.g. from a
config file), so we can't just assert() that it worked.

Change-Id: Iea2d4ab2c82d79f6eada24e6082456489bf304b8
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
parent 532de4d9

app/nvmf_tgt/conf.c

+7 −1
Original line number Diff line number Diff line
@@ -531,7 +531,13 @@ spdk_nvmf_construct_subsystem(const char *name, 


		listen_addr = spdk_nvmf_tgt_listen(addresses[i].transport,

						   addresses[i].traddr, addresses[i].trsvcid);

		assert(listen_addr != NULL);

		if (listen_addr == NULL) {

			SPDK_ERRLOG("Failed to listen on transport %s, traddr %s, trsvcid %s\n",

				    addresses[i].transport,

				    addresses[i].traddr,

				    addresses[i].trsvcid);

			goto error;

		}

		spdk_nvmf_subsystem_add_listener(subsystem, listen_addr);

	}