Commit 9396422b authored by Jin Yu's avatar Jin Yu Committed by Tomasz Zawadzki
Browse files

nvmf: fix aer request judgment 



Fix potential bug. In nvmf_ctrlr_abort_on_pg(), when run into
the request_complete it can trigger this bug because in nvmf_qpair_abort
the ctrlr->aer_req was set to NULL.

Change-Id: I37a7e3c76c6616ca4ecbc6d9d2776ee32449c796
Signed-off-by: default avatarJin Yu <jin.yu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2545


Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent fadfef63

lib/nvmf/ctrlr.c

+1 −1
Original line number Diff line number Diff line
@@ -2868,7 +2868,7 @@ spdk_nvmf_request_complete(struct spdk_nvmf_request *req) 
	qpair = req->qpair;

	if (qpair->ctrlr) {

		sgroup = &qpair->group->sgroups[qpair->ctrlr->subsys->id];

		is_aer = qpair->ctrlr->aer_req == req;

		is_aer = req->cmd->nvme_cmd.opc == SPDK_NVME_OPC_ASYNC_EVENT_REQUEST;

	} else if (spdk_unlikely(nvmf_request_is_fabric_connect(req))) {

		sgroup = nvmf_subsystem_pg_from_connect_cmd(req);

	}