Commit 93731ac7 authored by Marek Chomnicki's avatar Marek Chomnicki Committed by Tomasz Zawadzki
Browse files

rpc: unset default timeout value in arg parse 



The default value 60.0 is defined in JSONRPCClient.

Change-Id: I954893955db344421b74c328358faf05906b9fa7
Signed-off-by: default avatarMarek Chomnicki <marek.chomnicki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22585


Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarMichal Berger <michal.berger@intel.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 874550d7

python/spdk/rpc/client.py

+2 −2
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ class JSONRPCException(Exception): 




class JSONRPCClient(object):

    def __init__(self, addr, port=None, timeout=60.0, **kwargs):

    def __init__(self, addr, port=None, timeout=None, **kwargs):

        self.sock = None

        ch = logging.StreamHandler()

        ch.setFormatter(logging.Formatter('%(levelname)s: %(message)s'))
@@ -51,7 +51,7 @@ class JSONRPCClient(object): 
        self.log_set_level(kwargs.get('log_level', logging.ERROR))

        connect_retries = kwargs.get('conn_retries', 0)



        self.timeout = timeout

        self.timeout = timeout if timeout is not None else 60.0

        self._request_id = 0

        self._recv_buf = ""

        self._reqs = []

scripts/rpc.py

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ if __name__ == "__main__": 
                        default=5260, type=int)

    parser.add_argument('-t', dest='timeout',

                        help='Timeout as a floating point number expressed in seconds waiting for response. Default: 60.0',

                        default=60.0, type=float)

                        default=None, type=float)

    parser.add_argument('-r', dest='conn_retries',

                        help='Retry connecting to the RPC server N times with 0.2s interval. Default: 0',

                        default=0, type=int)