Commit 92df9955 authored by Michael Haeuptle's avatar Michael Haeuptle Committed by Tomasz Zawadzki
Browse files

json: increase the json rpc client value limit 



The jsonrpc client has a limit of 1024 JSON values per
request which is hardly enough for any meaningful config.
For example, calling getbdevs for 24 NVMe drives require
~2300 JSON values.
I kept the original 1024 limit for the RPC server where
it makes sense to have a smaller limit and introduced
a seperate limit for the client.

Signed-off-by: default avatarMichael Haeuptle <michael.haeuptle@hpe.com>
Change-Id: Id0300991b76151e4003e323f5ea29bc5fc0d2d11
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473568


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent a31ae23f

lib/jsonrpc/jsonrpc_client.c

+1 −1
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ spdk_jsonrpc_parse_response(struct spdk_jsonrpc_client *client) 
	}



	SPDK_DEBUGLOG(SPDK_LOG_RPC_CLIENT, "JSON string is :\n%s\n", client->recv_buf);

	if (rc < 0 || rc > SPDK_JSONRPC_MAX_VALUES) {

	if (rc < 0 || rc > SPDK_JSONRPC_CLIENT_MAX_VALUES) {

		SPDK_ERRLOG("JSON parse error (rc: %zd)\n", rc);

		/*

		 * Can't recover from parse error (no guaranteed resync point in streaming JSON).

lib/jsonrpc/jsonrpc_internal.h

+1 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ 
#define SPDK_JSONRPC_ID_MAX_LEN		128

#define SPDK_JSONRPC_MAX_CONNS		64

#define SPDK_JSONRPC_MAX_VALUES		1024

#define SPDK_JSONRPC_CLIENT_MAX_VALUES		8192



struct spdk_jsonrpc_request {

	struct spdk_jsonrpc_server_conn *conn;