Commit 91dc22ba authored by Pawel Kaminski's avatar Pawel Kaminski Committed by Tomasz Zawadzki
Browse files

test: shellcheck - move rule SC1083 to permanent exclude list 



SC1083: This {/} is literal. Check expression (missing ;/\n?) or quote it.
This rule points to places that are part of command
and cannot be fixed:
1. git archive HEAD^{tree}
2. vpp (e.g. dpdk { no-pci })

Change-Id: I30117913f964415cdaed94d29b1209d119e4d5a4
Signed-off-by: default avatarPawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/479986


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 7200ad81

scripts/check_format.sh

+3 −2
Original line number Diff line number Diff line
@@ -240,13 +240,14 @@ if hash shellcheck 2>/dev/null; then 
	# go to: https://trello.com/c/29Z90j1W

	# Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki

	# This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors.

	SHCK_EXCLUDE="SC1083,SC2002,SC2010,SC2034,SC2045"

	SHCK_EXCLUDE="SC2002,SC2010,SC2034,SC2045"

	# SPDK fails some error checks which have been deprecated in later versions of shellcheck.

	# We will not try to fix these error checks, but instead just leave the error types here

	# so that we can still run with older versions of shellcheck.

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1117"

	# SPDK has decided to not fix violations of these errors.

	# We are aware about below exclude list and we want this errors to be excluded.

	# SC1083: This {/} is literal. Check expression (missing ;/\n?) or quote it.

	# SC1090: Can't follow non-constant source. Use a directive to specify location.

	# SC1091: Not following: (error message here)

	# SC2001: See if you can use ${variable//search/replace} instead.
@@ -265,7 +266,7 @@ if hash shellcheck 2>/dev/null; then 
	#         or split robustly with mapfile or read -a.

	# SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).

	# SC2223: This default assignment may cause DoS due to globbing. Quote it.

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1090,SC1091,SC2015,SC2016,SC2046,SC2086,SC2119,SC2120,SC2148,\

	SHCK_EXCLUDE="$SHCK_EXCLUDE,SC1083,SC1090,SC1091,SC2015,SC2016,SC2046,SC2086,SC2119,SC2120,SC2148,\

SC2153,SC2154,SC2164,SC2174,SC2001,SC2206,SC2207,SC2223"



	SHCK_FORMAT="diff"