Commit 91a55bfe authored by Jim Harris's avatar Jim Harris Committed by Konrad Sztyber
Browse files

test/unit/blob: make payload buffers sized based on the cluster size 



Previously the payload buffers were twice as big as they needed to
be. This didn't really harm anything, but it raised questions why
they were that size. It's actually better to size them exactly as
needed, since then ASAN can catch overflows.

Signed-off-by: default avatarJim Harris <jim.harris@samsung.com>
Change-Id: I15e835703bcb147f770aad8e06c2bc6947abf276
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25311


Reviewed-by: default avatarBen Walker <ben@nvidia.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Community CI Samsung <spdk.community.ci.samsung@gmail.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
parent 9e554deb

test/unit/lib/blob/blob.c/blob_ut.c

+20 −20
Original line number Diff line number Diff line
@@ -6813,9 +6813,9 @@ static void 
test_io_write(struct spdk_bs_dev *dev, struct spdk_blob *blob, struct spdk_io_channel *channel)

{

	const uint32_t SZ = 32; /* size of cluster in 512-byte blocks */

	uint8_t payload_ff[64 * 512];

	uint8_t payload_aa[64 * 512];

	uint8_t payload_00[64 * 512];

	uint8_t payload_ff[SZ * 512];

	uint8_t payload_aa[SZ * 512];

	uint8_t payload_00[SZ * 512];

	uint8_t *cluster0, *cluster1;



	memset(payload_ff, 0xFF, sizeof(payload_ff));
@@ -6930,10 +6930,10 @@ static void 
test_io_read(struct spdk_bs_dev *dev, struct spdk_blob *blob, struct spdk_io_channel *channel)

{

	const uint32_t SZ = 32; /* size of cluster in 512-byte blocks */

	uint8_t payload_read[64 * 512];

	uint8_t payload_ff[64 * 512];

	uint8_t payload_aa[64 * 512];

	uint8_t payload_00[64 * 512];

	uint8_t payload_read[2 * SZ * 512];

	uint8_t payload_ff[SZ * 512];

	uint8_t payload_aa[SZ * 512];

	uint8_t payload_00[SZ * 512];



	memset(payload_ff, 0xFF, sizeof(payload_ff));

	memset(payload_aa, 0xAA, sizeof(payload_aa));
@@ -7042,9 +7042,9 @@ static void 
test_io_unmap(struct spdk_bs_dev *dev, struct spdk_blob *blob, struct spdk_io_channel *channel)

{

	const uint32_t SZ = 32; /* size of cluster in 512-byte blocks */

	uint8_t payload_ff[64 * 512];

	uint8_t payload_aa[64 * 512];

	uint8_t payload_00[64 * 512];

	uint8_t payload_ff[SZ * 512];

	uint8_t payload_aa[SZ * 512];

	uint8_t payload_00[SZ * 512];

	uint8_t *cluster0, *cluster1;



	memset(payload_ff, 0xFF, sizeof(payload_ff));
@@ -7068,9 +7068,9 @@ static void 
test_io_zeroes(struct spdk_bs_dev *dev, struct spdk_blob *blob, struct spdk_io_channel *channel)

{

	const uint32_t SZ = 32; /* size of cluster in 512-byte blocks */

	uint8_t payload_ff[64 * 512];

	uint8_t payload_aa[64 * 512];

	uint8_t payload_00[64 * 512];

	uint8_t payload_ff[SZ * 512];

	uint8_t payload_aa[SZ * 512];

	uint8_t payload_00[SZ * 512];

	uint8_t *cluster0, *cluster1;



	memset(payload_ff, 0xFF, sizeof(payload_ff));
@@ -7116,9 +7116,9 @@ test_iov_write(struct spdk_bs_dev *dev, struct spdk_blob *blob, struct spdk_io_c 
	       bool ext_api)

{

	const uint32_t SZ = 32; /* size of cluster in 512-byte blocks */

	uint8_t payload_ff[64 * 512];

	uint8_t payload_aa[64 * 512];

	uint8_t payload_00[64 * 512];

	uint8_t payload_ff[SZ * 512];

	uint8_t payload_aa[SZ * 512];

	uint8_t payload_00[SZ * 512];

	uint8_t *cluster0, *cluster1;

	struct iovec iov[4];

	struct spdk_blob_ext_io_opts ext_opts = {
@@ -7281,10 +7281,10 @@ test_iov_read(struct spdk_bs_dev *dev, struct spdk_blob *blob, struct spdk_io_ch 
	      bool ext_api)

{

	const uint32_t SZ = 32; /* size of cluster in 512-byte blocks */

	uint8_t payload_read[64 * 512];

	uint8_t payload_ff[64 * 512];

	uint8_t payload_aa[64 * 512];

	uint8_t payload_00[64 * 512];

	uint8_t payload_read[2 * SZ * 512];

	uint8_t payload_ff[SZ * 512];

	uint8_t payload_aa[SZ * 512];

	uint8_t payload_00[SZ * 512];

	struct iovec iov[4];

	struct spdk_blob_ext_io_opts ext_opts = {

		.memory_domain = (struct spdk_memory_domain *)0xfeedbeef,