Commit 90761053 authored by Karol Latecki's avatar Karol Latecki Committed by Tomasz Zawadzki
Browse files

scripts/nvmf_perf: stop pcm-memory using sigterm 



Use terminate() instead of kill() to exit more gracefully.
Using kill() resulted in (sometimes) output not being saved.

Signed-off-by: default avatarKarol Latecki <karol.latecki@intel.com>
Change-Id: I3ff1dec8cb0804f6e0674c5ed61bbe4ec9ea70ef
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6045


Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 79199d41

scripts/perf/nvmf/run_nvmf.py

+1 −1
Original line number Diff line number Diff line
@@ -268,7 +268,7 @@ class Target(Server): 
        pcm_memory = subprocess.Popen("%s/pcm-memory.x %s -csv=%s/%s" % (self.pcm_dir, self.pcm_interval,

                                      results_dir, pcm_file_name), shell=True)

        time.sleep(self.pcm_count)

        pcm_memory.kill()

        pcm_memory.terminate()



    def measure_pcm(self, results_dir, pcm_file_name):

        time.sleep(self.pcm_delay)