Commit 8f15778f authored by Sebastian Brzezinka's avatar Sebastian Brzezinka Committed by Jim Harris
Browse files

scripts/check_format.sh: Add check for `extern "C"` 



Fixes #3272.

Change-Id: I4b8304fff413f9637acc4340194a13246a472776
Signed-off-by: default avatarSebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/22571


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Reviewed-by: default avatarMichal Berger <michal.berger@intel.com>
Reviewed-by: default avatarMarcin Spiewak <marcin.spiewak@intel.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent da6841e4

scripts/check_format.sh

+19 −0
Original line number Diff line number Diff line
@@ -886,6 +886,24 @@ function get_diffed_dups() { 
	fi

}



function check_extern_c() {

	local files_missing_extern_c=()



	printf 'Checking extern "C"... '



	mapfile -t files_missing_extern_c < <(

		grep -LE "extern \"C\"" $(git ls-files -- ./include/spdk/*.h)

	)



	if ((${#files_missing_extern_c[@]} > 0)); then

		printf '\nFollowing header files are missing extern C:\n'

		printf '  %s\n' "${files_missing_extern_c[@]}"

		return 1

	fi



	printf 'OK\n'

}



rc=0



check_permissions || rc=1
@@ -919,5 +937,6 @@ check_json_rpc || rc=1 
check_rpc_args || rc=1

check_spdx_lic || rc=1

check_golang_style || rc=1

check_extern_c || rc=1



exit $rc