Commit 8e7d5592 authored by Ben Walker's avatar Ben Walker Committed by Tomasz Zawadzki
Browse files

sock/posix: When a socket has no recv_pipe, reading should still clear 


from pending_recv list

If the upper layer performs a read/recv, it should still remove the
socket from the pending_recv list.

Change-Id: I32ca8ecccbfe1e53ecc7d6f57343c2727e84b851
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6743


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 18020ec7

module/sock/posix/posix.c

+5 −0
Original line number Diff line number Diff line
@@ -923,10 +923,15 @@ static ssize_t 
posix_sock_readv(struct spdk_sock *_sock, struct iovec *iov, int iovcnt)

{

	struct spdk_posix_sock *sock = __posix_sock(_sock);

	struct spdk_posix_sock_group_impl *group = __posix_group_impl(sock->base.group_impl);

	int rc, i;

	size_t len;



	if (sock->recv_pipe == NULL) {

		if (group && sock->pending_recv) {

			sock->pending_recv = false;

			TAILQ_REMOVE(&group->pending_recv, sock, link);

		}

		return readv(sock->fd, iov, iovcnt);

	}