Commit 8e65bfc7 authored by Seth Howell's avatar Seth Howell Committed by Tomasz Zawadzki
Browse files

lib/log: add a check for localtime() failure 



localtime() can technically fail and return a NULL
pointer. We should handle this case.

Change-Id: I5f9d11c5f992453ec3e3804bd17f5d05a863d526
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3245


Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent c7d1abba

lib/log/log.c

+4 −0
Original line number Diff line number Diff line
@@ -76,6 +76,10 @@ get_timestamp_prefix(char *buf, int buf_size) 
	clock_gettime(CLOCK_REALTIME, &ts);

	info = localtime(&ts.tv_sec);

	usec = ts.tv_nsec / 1000;

	if (info == NULL) {

		snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);

		return;

	}



	strftime(date, sizeof(date), "%Y-%m-%d %H:%M:%S", info);

	snprintf(buf, buf_size, "[%s.%06ld] ", date, usec);