Commit 8d2c5200 authored by paul luse's avatar paul luse Committed by Tomasz Zawadzki
Browse files

lib/idxd: add support for dual cast 



Dual-cast copies the same source to two separate destination buffers.

Signed-off-by: default avatarpaul luse <paul.e.luse@intel.com>
Change-Id: Icadae34a75c35e2db672a193287b147416012a5a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2129


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Community-CI: Mellanox Build Bot
parent 40ec8e97

doc/idxd.md

+3 −0
Original line number Diff line number Diff line
@@ -10,6 +10,9 @@ Function | Description 
--------------------------------------- | -----------

spdk_idxd_probe()                       | @copybrief spdk_idxd_probe()

spdk_idxd_submit_copy()                 | @copybrief spdk_idxd_submit_copy()

spdk_idxd_submit_compare()              | @copybrief spdk_idxd_submit_compare()

spdk_idxd_submit_crc32c()               | @copybrief spdk_idxd_submit_crc32c()

spdk_idxd_submit_dualcast               | @copybrief spdk_idxd_submit_dualcast()

spdk_idxd_submit_fill()                 | @copybrief spdk_idxd_submit_fill()



# Pre-defined configurations {#idxd_configs}

include/spdk/idxd.h

+21 −0
Original line number Diff line number Diff line
@@ -157,6 +157,27 @@ int spdk_idxd_submit_copy(struct spdk_idxd_io_channel *chan, 
			  void *dst, const void *src, uint64_t nbytes,

			  spdk_idxd_req_cb cb_fn, void *cb_arg);



/**

 * Build and submit an accel engine dual cast copy request.

 *

 * This function will build the dual cast descriptor and then immediately submit

 * by writing to the proper device portal.

 *

 * \param chan IDXD channel to submit request.

 * \param dst1 First destination virtual address (must be 4K aligned).

 * \param dst2 Second destination virtual address (must be 4K aligned).

 * \param src Source virtual address.

 * \param nbytes Number of bytes to copy.

 * \param cb_fn Callback function which will be called when the request is complete.

 * \param cb_arg Opaque value which will be passed back as the arg parameter in

 * the completion callback.

 *

 * \return 0 on success, negative errno on failure.

 */

int spdk_idxd_submit_dualcast(struct spdk_idxd_io_channel *chan,

			      void *dst1, void *dst2, const void *src, uint64_t nbytes,

			      spdk_idxd_req_cb cb_fn, void *cb_arg);



/**

 * Build and submit a memory compare request.

 *

include/spdk_internal/accel_engine.h

+2 −0
Original line number Diff line number Diff line
@@ -48,6 +48,8 @@ struct spdk_accel_engine { 
	uint64_t (*get_capabilities)(void);

	int (*copy)(void *cb_arg, struct spdk_io_channel *ch, void *dst, void *src,

		    uint64_t nbytes, spdk_accel_completion_cb cb);

	int (*dualcast)(void *cb_arg, struct spdk_io_channel *ch, void *dst1, void *dst2, void *src,

			uint64_t nbytes, spdk_accel_completion_cb cb);

	int (*compare)(void *cb_arg, struct spdk_io_channel *ch, void *src1, void *src2,

		       uint64_t nbytes, spdk_accel_completion_cb cb);

	int (*fill)(void *cb_arg, struct spdk_io_channel *ch, void *dst, uint8_t fill,

lib/idxd/idxd.c

+33 −0
Original line number Diff line number Diff line
@@ -43,6 +43,8 @@ 


#include "idxd.h"



#define ALIGN_4K 0x1000



pthread_mutex_t	g_driver_lock = PTHREAD_MUTEX_INITIALIZER;



/*
@@ -688,6 +690,37 @@ spdk_idxd_submit_copy(struct spdk_idxd_io_channel *chan, void *dst, const void * 
	return 0;

}



/* Dual-cast copies the same source to two separate destination buffers. */

int

spdk_idxd_submit_dualcast(struct spdk_idxd_io_channel *chan, void *dst1, void *dst2,

			  const void *src, uint64_t nbytes, spdk_idxd_req_cb cb_fn, void *cb_arg)

{

	struct idxd_hw_desc *desc;



	if ((uintptr_t)dst1 & (ALIGN_4K - 1) || (uintptr_t)dst2 & (ALIGN_4K - 1)) {

		SPDK_ERRLOG("Dualcast requires 4K alignment on dst addresses\n");

		return -EINVAL;

	}



	/* Common prep. */

	desc = _idxd_prep_command(chan, cb_fn, cb_arg);

	if (desc == NULL) {

		return -EBUSY;

	}



	/* Command specific. */

	desc->opcode = IDXD_OPCODE_DUALCAST;

	desc->src_addr = (uintptr_t)src;

	desc->dst_addr = (uintptr_t)dst1;

	desc->dest2 = (uintptr_t)dst2;

	desc->xfer_size = nbytes;



	/* Submit operation. */

	movdir64b((uint64_t *)chan->ring_ctrl.portal, desc);



	return 0;

}



int

spdk_idxd_submit_compare(struct spdk_idxd_io_channel *chan, void *src1, const void *src2,

			 uint64_t nbytes,

lib/idxd/spdk_idxd.map

+1 −0
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ 
	spdk_idxd_submit_compare;

	spdk_idxd_submit_crc32c;

	spdk_idxd_submit_copy;

	spdk_idxd_submit_dualcast;

	spdk_idxd_submit_fill;

	spdk_idxd_process_events;

	spdk_idxd_get_channel;