Commit 8caf8f5e authored by Mike Gerdts's avatar Mike Gerdts Committed by Jim Harris
Browse files

blob: report unexpected descriptor types 



When printing blob metadata via blobcli, descriptor types that do not
have full dump support should not be silently ignored. This prints a
message that indicates an unsupported descriptor type was encountered
so that the person debugging with blobcli knows that there is more
metadata present.

Signed-off-by: default avatarMike Gerdts <mgerdts@nvidia.com>
Change-Id: Id30b671fd9dee1ec12e10625eb2af4c1e43eda27
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11258


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarShuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 6e440ff1

lib/blob/blobstore.c

+1 −0
Original line number Diff line number Diff line
@@ -4788,6 +4788,7 @@ bs_dump_print_md_page(struct spdk_bs_load_ctx *ctx) 
			bs_dump_print_type_flags(ctx, desc);

		} else {

			/* Error */

			fprintf(ctx->fp, "Unknown descriptor type %" PRIu8 "\n", desc->type);

		}

		/* Advance to the next descriptor */

		cur_desc += sizeof(*desc) + desc->length;