Commit 8c400e49 authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

idxd: Remove unused nop_check callback 



Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Change-Id: Ibda86694edc10a3edec8cb85638b4950647b13eb
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11435


Reviewed-by: default avatarPaul Luse <paul.e.luse@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 7ddc75ab

lib/idxd/idxd.h

+0 −2
Original line number Diff line number Diff line
@@ -162,8 +162,6 @@ struct spdk_idxd_impl { 
	void (*destruct)(struct spdk_idxd_device *idxd);

	void (*dump_sw_error)(struct spdk_idxd_device *idxd, void *portal);

	char *(*portal_get_addr)(struct spdk_idxd_device *idxd);

	/* It is a workaround for simulator */

	bool (*nop_check)(struct spdk_idxd_device *idxd);



	STAILQ_ENTRY(spdk_idxd_impl) link;

};

lib/idxd/idxd_user.c

+1 −15
Original line number Diff line number Diff line
@@ -550,27 +550,13 @@ user_idxd_portal_get_addr(struct spdk_idxd_device *idxd) 
	return (char *)idxd->portals + idxd->wq_id * WQ_TOTAL_PORTAL_SIZE;

}



static bool

user_idxd_nop_check(struct spdk_idxd_device *idxd)

{

	struct spdk_user_idxd_device *user_idxd = __user_idxd(idxd);



	/* TODO: temp workaround for simulator.  Remove this function when fixed or w/silicon. */

	if (user_idxd->registers.gencap.raw == 0x1833f011f) {

		return true;

	}



	return false;

}



static struct spdk_idxd_impl g_user_idxd_impl = {

	.name			= "user",

	.set_config		= user_idxd_set_config,

	.probe			= user_idxd_probe,

	.destruct		= user_idxd_device_destruct,

	.dump_sw_error		= user_idxd_dump_sw_err,

	.portal_get_addr	= user_idxd_portal_get_addr,

	.nop_check		= user_idxd_nop_check,

	.portal_get_addr	= user_idxd_portal_get_addr

};



/* Caller must hold g_driver_lock */