Commit 8be59045 authored by Weiguo Li's avatar Weiguo Li Committed by Jim Harris
Browse files

thread: fix double unlock in spdk_io_device_register 



Since there is a pthread_mutex_unlock() in normal condition, another
pthread_mutex_unlock() in the "tmp != NULL" branch should be removed,
otherwise will cause a double unlock.

Fixes issue #2378.

Signed-off-by: default avatarWeiguo Li <liwg06@foxmail.com>
Change-Id: I6c80a9527dd60e0b7c1d3c54b6da371b31118f02
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11642


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent af2bd578

lib/thread/thread.c

+0 −1
Original line number Diff line number Diff line
@@ -1992,7 +1992,6 @@ spdk_io_device_register(void *io_device, spdk_io_channel_create_cb create_cb, 
	if (tmp != NULL) {

		SPDK_ERRLOG("io_device %p already registered (old:%s new:%s)\n",

			    io_device, tmp->name, dev->name);

		pthread_mutex_unlock(&g_devlist_mutex);

		free(dev);

	}