Commit 8b69f6b8 authored by Ben Walker's avatar Ben Walker Committed by Changpeng Liu
Browse files

nvme: Don't do a write memory barrier if we don't ring the doorbell 



Change-Id: I6766ae96c155e04bc0162aa8d2e21fd096be3221
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448310


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent e6c2ff37

lib/nvme/nvme_pcie.c

+1 −1
Original line number Diff line number Diff line
@@ -1190,11 +1190,11 @@ nvme_pcie_qpair_submit_tracker(struct spdk_nvme_qpair *qpair, struct nvme_tracke 
		SPDK_ERRLOG("sq_tail is passing sq_head!\n");

	}



	spdk_wmb();

	if (spdk_likely(nvme_pcie_qpair_update_mmio_required(qpair,

			pqpair->sq_tail,

			pqpair->sq_shadow_tdbl,

			pqpair->sq_eventidx))) {

		spdk_wmb();

		g_thread_mmio_ctrlr = pctrlr;

		spdk_mmio_write_4(pqpair->sq_tdbl, pqpair->sq_tail);

		g_thread_mmio_ctrlr = NULL;