Commit 8a6ba58c authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Jim Harris
Browse files

scripts/check_format: check for spaces before tabs 



Automatically detect more whitespace errors.

All existing cases are fixed; only whitespace change (verify with
diff -w) except for one comment style fixup in include/spdk/nvme.h.

Change-Id: If750e54b9c8e3421ea6feda5f20184a31431631e
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/402360


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent a76da19f

include/spdk/nvme.h

+4 −4
Original line number Diff line number Diff line
@@ -1281,7 +1281,7 @@ int spdk_nvme_ns_cmd_read_with_md(struct spdk_nvme_ns *ns, struct spdk_nvme_qpai 
 * \param type A bit field constructed from \ref enum spdk_nvme_dsm_attribute.

 * \param qpair I/O queue pair to submit the request

 * \param ranges An array of \ref spdk_nvme_dsm_range elements describing

 		 the LBAs to operate on.

 *		 the LBAs to operate on.

 * \param num_ranges The number of elements in the ranges array.

 * \param cb_fn callback function to invoke when the I/O is completed

 * \param cb_arg argument to pass to the callback function

scripts/check_format.sh

+11 −0
Original line number Diff line number Diff line
@@ -51,6 +51,17 @@ else 
fi

rm -f comment.log



echo -n "Checking for spaces before tabs..."

git grep --line-number $' \t' -- > whitespace.log || true

if [ -s whitespace.log ]; then

	echo " Spaces before tabs detected"

	cat whitespace.log

	rc=1

else

	echo " OK"

fi

rm -f whitespace.log



echo -n "Checking trailing whitespace in output strings..."



git grep --line-number -e ' \\n"' -- '*.[ch]' > whitespace.log || true

lib/nvmf/ctrlr_bdev.c

+4 −4

File changed.

Contains only whitespace changes.

test/lib/nvme/reset/reset.c

+3 −3

File changed.

Contains only whitespace changes.

examples/nvme/perf/perf.c

+1 −1

File changed.

Contains only whitespace changes.

include/spdk/scsi_spec.h

+1 −1

File changed.

Contains only whitespace changes.

lib/scsi/scsi_internal.h

+1 −1

File changed.

Contains only whitespace changes.

test/spdk_cunit.h

+1 −1

File changed.

Contains only whitespace changes.

include/spdk_internal/copy_engine.h

+6 −6

File changed.

Contains only whitespace changes.

lib/net/interface.c

+8 −8

File changed.

Contains only whitespace changes.

app/nvmf_tgt/nvmf_rpc.c

+1 −1

File changed.

Contains only whitespace changes.

lib/bdev/nvme/bdev_nvme_rpc.c

+3 −3

File changed.

Contains only whitespace changes.

lib/blob/request.h

+3 −3

File changed.

Contains only whitespace changes.

lib/nvmf/nvmf_internal.h

+6 −6

File changed.

Contains only whitespace changes.

include/spdk/nvmf_spec.h

+2 −2

File changed.

Contains only whitespace changes.

include/spdk_internal/bdev.h

+6 −6

File changed.

Contains only whitespace changes.

lib/env_dpdk/env_internal.h

+1 −1

File changed.

Contains only whitespace changes.

test/unit/lib/lvol/lvol.c/lvol_ut.c

+1 −1

File changed.

Contains only whitespace changes.

examples/nvme/fio_plugin/fio_plugin.c

+3 −3

File changed.

Contains only whitespace changes.

lib/nvmf/rdma.c

+17 −17

File changed.

Contains only whitespace changes.

test/lib/nvme/overhead/overhead.c

+1 −1

File changed.

Contains only whitespace changes.

examples/nvme/reserve/reserve.c

+2 −2

File changed.

Contains only whitespace changes.

lib/scsi/scsi_bdev.c

+1 −1

File changed.

Contains only whitespace changes.

test/unit/lib/nvme/nvme_pcie.c/nvme_pcie_ut.c

+5 −5

File changed.

Contains only whitespace changes.

lib/iscsi/tgt_node.c

+2 −2

File changed.

Contains only whitespace changes.

lib/nvme/nvme_pcie.c

+1 −1

File changed.

Contains only whitespace changes.

test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c

+1 −1

File changed.

Contains only whitespace changes.

include/spdk/queue_extras.h

+2 −2

File changed.

Contains only whitespace changes.

include/spdk/scsi.h

+1 −1

File changed.

Contains only whitespace changes.

lib/bdev/lvol/vbdev_lvol.h

+1 −1

File changed.

Contains only whitespace changes.

lib/blob/blobstore.h

+3 −3

File changed.

Contains only whitespace changes.

test/lib/env/vtophys/vtophys.c

+1 −1

File changed.

Contains only whitespace changes.

lib/ioat/ioat.c

+1 −1

File changed.

Contains only whitespace changes.

test/lib/bdev/bdevio/bdevio.c

+1 −1

File changed.

Contains only whitespace changes.

test/lib/bdev/bdevperf/bdevperf.c

+1 −1

File changed.

Contains only whitespace changes.

examples/ioat/perf/perf.c

+1 −1

File changed.

Contains only whitespace changes.

examples/nvme/nvme_manage/nvme_manage.c

+6 −6

File changed.

Contains only whitespace changes.

lib/bdev/bdev.c

+1 −1

File changed.

Contains only whitespace changes.

include/spdk/env.h

+6 −6

File changed.

Contains only whitespace changes.

lib/nvmf/nvmf.c

+12 −12

File changed.

Contains only whitespace changes.

test/lib/nvme/aer/aer.c

+1 −1

File changed.

Contains only whitespace changes.

lib/event/reactor.c

+2 −2

File changed.

Contains only whitespace changes.

lib/iscsi/tgt_node.h

+1 −1

File changed.

Contains only whitespace changes.

lib/nvme/nvme_transport.c

+1 −1

File changed.

Contains only whitespace changes.

test/lib/nvme/sgl/sgl.c

+1 −1

File changed.

Contains only whitespace changes.

test/unit/lib/scsi/lun.c/lun_ut.c

+1 −1

File changed.

Contains only whitespace changes.

include/spdk/nvme_spec.h

+1 −1

File changed.

Contains only whitespace changes.

lib/bdev/aio/bdev_aio.c

+4 −4

File changed.

Contains only whitespace changes.

lib/nvme/nvme_qpair.c

+1 −1

File changed.

Contains only whitespace changes.

test/unit/lib/blob/blob.c/blob_ut.c

+2 −2

File changed.

Contains only whitespace changes.

test/unit/lib/event/subsystem.c/subsystem_ut.c

+1 −1

File changed.

Contains only whitespace changes.

examples/nvme/identify/identify.c

+1 −1

File changed.

Contains only whitespace changes.

lib/bdev/malloc/bdev_malloc.c

+1 −1

File changed.

Contains only whitespace changes.

lib/blob/blobstore.c

+22 −22

File changed.

Contains only whitespace changes.

lib/nvme/nvme_rdma.c

+10 −10

File changed.

Contains only whitespace changes.

test/lib/nvme/e2edp/nvme_dp.c

+1 −1

File changed.

Contains only whitespace changes.

test/unit/lib/scsi/scsi.c/scsi_ut.c

+1 −1

File changed.

Contains only whitespace changes.

include/spdk/event.h

+1 −1

File changed.

Contains only whitespace changes.

include/spdk/trace.h

+1 −1

File changed.

Contains only whitespace changes.

lib/nvme/nvme_ctrlr.c

+1 −1

File changed.

Contains only whitespace changes.

examples/bdev/fio_plugin/fio_plugin.c

+2 −2

File changed.

Contains only whitespace changes.