Commit 8a252783 authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

log: remove old-style errlog entries. 



SPDK_ERRLOG lists the function name, so remove old references that
assume it doesn't and reprint the function name.

Change-Id: I69da6ca0a25bf0eda07d8dad52bcfadf964ac715
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469487


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent e0e4f4ea

lib/blob/blobstore.c

+1 −1
Original line number Diff line number Diff line
@@ -1803,7 +1803,7 @@ _spdk_blob_request_submit_op_split_next(void *cb_arg, int bserrno) 
		break;

	case SPDK_BLOB_READV:

	case SPDK_BLOB_WRITEV:

		SPDK_ERRLOG("readv/write not valid for %s\n", __func__);

		SPDK_ERRLOG("readv/write not valid\n");

		spdk_bs_sequence_finish(ctx->seq, -EINVAL);

		free(ctx);

		break;

lib/env_dpdk/memory.c

+2 −2
Original line number Diff line number Diff line
@@ -1000,8 +1000,8 @@ spdk_vtophys_notify(void *cb_ctx, struct spdk_mem_map *map, 
	}



	if (((uintptr_t)vaddr & MASK_2MB) || (len & MASK_2MB)) {

		DEBUG_PRINT("invalid %s parameters, vaddr=%p len=%ju\n",

			    __func__, vaddr, len);

		DEBUG_PRINT("invalid parameters, vaddr=%p len=%ju\n",

			    vaddr, len);

		return -EINVAL;

	}

lib/net/interface.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static int spdk_process_new_interface_msg(struct nlmsghdr *h) 


	ifc = (struct spdk_interface *) malloc(sizeof(*ifc));

	if (ifc == NULL) {

		SPDK_ERRLOG("%s: Malloc failed\n", __func__);

		SPDK_ERRLOG("Malloc failed\n");

		return 1;

	}

lib/nvme/nvme_ctrlr.c

+2 −2
Original line number Diff line number Diff line
@@ -674,7 +674,7 @@ nvme_ctrlr_enable(struct spdk_nvme_ctrlr *ctrlr) 
	}



	if (cc.bits.en != 0) {

		SPDK_ERRLOG("%s called with CC.EN = 1\n", __func__);

		SPDK_ERRLOG("called with CC.EN = 1\n");

		return -EINVAL;

	}
@@ -986,7 +986,7 @@ spdk_nvme_ctrlr_reset(struct spdk_nvme_ctrlr *ctrlr) 


	while (ctrlr->state != NVME_CTRLR_STATE_READY) {

		if (nvme_ctrlr_process_init(ctrlr) != 0) {

			SPDK_ERRLOG("%s: controller reinitialization failed\n", __func__);

			SPDK_ERRLOG("controller reinitialization failed\n");

			nvme_ctrlr_fail(ctrlr, false);

			rc = -1;

			break;

lib/nvme/nvme_pcie.c

+1 −2
Original line number Diff line number Diff line
@@ -639,8 +639,7 @@ nvme_pcie_ctrlr_free_cmb_io_buffer(struct spdk_nvme_ctrlr *ctrlr, void *buf, siz 
	 * Do nothing for now.

	 * TODO: Track free space so buffers may be reused.

	 */

	SPDK_ERRLOG("%s: no deallocation for CMB buffers yet!\n",

		    __func__);

	SPDK_ERRLOG("no deallocation for CMB buffers yet!\n");

	return 0;

}