Commit 88e26908 authored by Seth Howell's avatar Seth Howell Committed by Daniel Verkamp
Browse files

test/unit: fix several scan-build errors. 



These errors occur when scan-build is used with clang 6.0 as a backend.

Change-Id: I751a0fd3649ae500887a4dbda1d361104acb7c12
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/418233


Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
parent 5b072d37

test/unit/lib/bdev/vbdev_lvol.c/vbdev_lvol_ut.c

+5 −10
Original line number Diff line number Diff line
@@ -861,7 +861,7 @@ ut_lvol_clone(void) 
	g_lvolerrno = -1;

	rc = vbdev_lvol_create(g_lvs, "lvol", sz, false, vbdev_lvol_create_complete, NULL);

	SPDK_CU_ASSERT_FATAL(rc == 0);

	CU_ASSERT(g_lvol != NULL);

	SPDK_CU_ASSERT_FATAL(g_lvol != NULL);

	CU_ASSERT(g_lvolerrno == 0);



	lvol = g_lvol;
@@ -869,7 +869,7 @@ ut_lvol_clone(void) 
	/* Successful snap create */

	vbdev_lvol_create_snapshot(lvol, "snap", vbdev_lvol_create_complete, NULL);

	SPDK_CU_ASSERT_FATAL(rc == 0);

	CU_ASSERT(g_lvol != NULL);

	SPDK_CU_ASSERT_FATAL(g_lvol != NULL);

	CU_ASSERT(g_lvolerrno == 0);



	snap = g_lvol;
@@ -878,7 +878,7 @@ ut_lvol_clone(void) 
	vbdev_lvol_create_clone(snap, "clone", vbdev_lvol_create_complete, NULL);



	SPDK_CU_ASSERT_FATAL(rc == 0);

	CU_ASSERT(g_lvol != NULL);

	SPDK_CU_ASSERT_FATAL(g_lvol != NULL);

	CU_ASSERT(g_lvolerrno == 0);



	clone = g_lvol;
@@ -943,12 +943,6 @@ ut_lvol_examine(void) 
	g_lvserrno = 0;

	g_examine_done = false;



	/* Examine with NULL bdev */

	vbdev_lvs_examine(NULL);

	CU_ASSERT(g_bs_dev == NULL);

	CU_ASSERT(g_lvol_store == NULL);

	CU_ASSERT(g_examine_done == true);



	/* Examine unsuccessfully - bdev already opened */

	g_bs_dev = NULL;

	g_examine_done = false;
@@ -1375,15 +1369,16 @@ ut_lvol_read_write(void) 
static void

ut_vbdev_lvol_submit_request(void)

{

	struct spdk_lvol request_lvol = {};

	g_io = calloc(1, sizeof(struct spdk_bdev_io) + sizeof(struct lvol_task));

	SPDK_CU_ASSERT_FATAL(g_io != NULL);

	g_base_bdev = calloc(1, sizeof(struct spdk_bdev));

	SPDK_CU_ASSERT_FATAL(g_base_bdev != NULL);

	g_task = (struct lvol_task *)g_io->driver_ctx;



	g_io->bdev = g_base_bdev;



	g_io->type = SPDK_BDEV_IO_TYPE_READ;

	g_base_bdev->ctxt = &request_lvol;

	vbdev_lvol_submit_request(g_ch, g_io);



	free(g_io);