Commit 87211463 authored by Ben Walker's avatar Ben Walker
Browse files

bdev: Fix data type mismatch for io_per_sec 



Change-Id: I6bf491bd9661d247a70d7ee323c14397cd577636
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/407367


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 2931d638

lib/bdev/bdev.c

+4 −4
Original line number Diff line number Diff line
@@ -2374,7 +2374,7 @@ _spdk_bdev_qos_config(struct spdk_bdev *bdev) 
{

	struct spdk_conf_section	*sp = NULL;

	const char			*val = NULL;

	int				ios_per_sec = 0;

	uint64_t			ios_per_sec = 0;

	int				i = 0;



	sp = spdk_conf_find_section(NULL, "QoS");
@@ -2398,14 +2398,14 @@ _spdk_bdev_qos_config(struct spdk_bdev *bdev) 
			return;

		}



		ios_per_sec = (int)strtol(val, NULL, 10);

		ios_per_sec = strtoull(val, NULL, 10);

		if (ios_per_sec > 0) {

			if (ios_per_sec % SPDK_BDEV_QOS_MIN_IOS_PER_SEC) {

				SPDK_ERRLOG("Assigned IOPS %u on bdev %s is not multiple of %u\n",

				SPDK_ERRLOG("Assigned IOPS %" PRIu64 " on bdev %s is not multiple of %u\n",

					    ios_per_sec, bdev->name, SPDK_BDEV_QOS_MIN_IOS_PER_SEC);

				SPDK_ERRLOG("Failed to enable QoS on this bdev %s\n", bdev->name);

			} else {

				bdev->ios_per_sec = (uint64_t)ios_per_sec;

				bdev->ios_per_sec = ios_per_sec;

				SPDK_DEBUGLOG(SPDK_LOG_BDEV, "Bdev:%s QoS:%lu\n",

					      bdev->name, bdev->ios_per_sec);

			}