Commit 85a7f53e authored Nov 25, 2019 by Jim Harris Committed by Tomasz Zawadzki Nov 28, 2019

bdev/nvme: remove NOTICELOGS in update ns path



We're going to reuse this code in a more common path
which would raise the visibility of these noticelogs
significantly.  These aren't exceptional conditions,
so there's no need to print them when they happen.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I1b56e3a4e5603e223bae07dc1c9e1ada03ba5901

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475793


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>

parent 9a78ffbb

module/bdev/nvme/bdev_nvme.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1045,7 +1045,6 @@ nvme_ctrlr_update_ns_bdevs(struct nvme_bdev_ctrlr *nvme_bdev_ctrlr)

		ns = nvme_bdev_ctrlr->namespaces[i];
		if (!ns->active && spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {
		SPDK_NOTICELOG("NSID %u to be added\n", nsid);
		ns->id = nsid;
		ns->ctrlr = nvme_bdev_ctrlr;

		@@ -1060,7 +1059,6 @@ nvme_ctrlr_update_ns_bdevs(struct nvme_bdev_ctrlr *nvme_bdev_ctrlr)
		}

		if (ns->active && !spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {
		SPDK_NOTICELOG("NSID %u is removed\n", nsid);
		nvme_ctrlr_deactivate_namespace(ns);
		}
		}