Commit 84501695 authored by liu-wenhua's avatar liu-wenhua Committed by Daniel Verkamp
Browse files

nvmf: Data transfer cannot be simply determined by NVMe opcode (#120) 

Whether a nvme command having data transfer cannot be completely
determined by command opcode. For set features command, some features
don't require data transfer.
Change spdk_nvmf_request_prep_data to fix this issue.
parent 08c69c9c

lib/nvmf/rdma.c

+13 −0
Original line number Diff line number Diff line
@@ -825,6 +825,19 @@ spdk_nvmf_request_prep_data(struct spdk_nvmf_request *req) 
		req->xfer = spdk_nvme_opc_get_data_transfer(req->cmd->nvmf_cmd.fctype);

	} else {

		req->xfer = spdk_nvme_opc_get_data_transfer(cmd->opc);

		if ((req->conn->type == CONN_TYPE_AQ) &&

		    ((cmd->opc == SPDK_NVME_OPC_GET_FEATURES) ||

		     (cmd->opc == SPDK_NVME_OPC_SET_FEATURES))) {

			switch (cmd->cdw10 & 0xff) {

			case SPDK_NVME_FEAT_LBA_RANGE_TYPE:

			case SPDK_NVME_FEAT_AUTONOMOUS_POWER_STATE_TRANSITION:

			case SPDK_NVME_FEAT_HOST_IDENTIFIER:

				break;

			default:

				req->xfer = SPDK_NVME_DATA_NONE;

				break;

			}

		}

	}



	if (req->xfer == SPDK_NVME_DATA_NONE) {