Commit 84482f44 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

ut/iscsi: Unit test for PDU header handling 



Add unit tests for PDU header handling except for SNACK Request PDU
because the caes that Error Recovery Level is not matured yet.

The purpose is mainly for increasing coverage, and most were reviewed
separately, and so merge multiple PDU types into a single patch.

Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ice8c522bee0fc8c0dadb0c6326be9f65d323d52e
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471955


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 3c4dfbd3

test/unit/lib/iscsi/common.c

+11 −0
Original line number Diff line number Diff line
@@ -16,6 +16,9 @@ SPDK_LOG_REGISTER_COMPONENT("iscsi", SPDK_LOG_ISCSI) 


TAILQ_HEAD(, spdk_iscsi_pdu) g_write_pdu_list = TAILQ_HEAD_INITIALIZER(g_write_pdu_list);



static bool g_task_pool_is_empty = false;

static bool g_pdu_pool_is_empty = false;



struct spdk_iscsi_task *

spdk_iscsi_task_get(struct spdk_iscsi_conn *conn,

		    struct spdk_iscsi_task *parent,
@@ -23,6 +26,10 @@ spdk_iscsi_task_get(struct spdk_iscsi_conn *conn, 
{

	struct spdk_iscsi_task *task;



	if (g_task_pool_is_empty) {

		return NULL;

	}



	task = calloc(1, sizeof(*task));

	if (!task) {

		return NULL;
@@ -63,6 +70,10 @@ spdk_get_pdu(void) 
{

	struct spdk_iscsi_pdu *pdu;



	if (g_pdu_pool_is_empty) {

		return NULL;

	}



	pdu = malloc(sizeof(*pdu));

	if (!pdu) {

		return NULL;

test/unit/lib/iscsi/iscsi.c/iscsi_ut.c

+699 −0

File changed.

Preview size limit exceeded, changes collapsed.