Commit 83b6f7e4 authored by Konrad Sztyber's avatar Konrad Sztyber Committed by Tomasz Zawadzki
Browse files

nvme/tcp: zero out PSK on TLS PSK derivation failure 



Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I249e9705fe1df0dc60e9bb00fc0d5f271e0277f5
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/21744


Reviewed-by: default avatarJim Harris <jim.harris@samsung.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 4c18542e

lib/nvme/nvme_tcp.c

+1 −2
Original line number Diff line number Diff line
@@ -2602,12 +2602,11 @@ nvme_tcp_generate_tls_credentials(struct nvme_tcp_ctrlr *tctrlr) 
				     sizeof(tctrlr->psk), tls_cipher_suite);

	if (rc < 0) {

		SPDK_ERRLOG("Could not generate TLS PSK!\n");

		return rc;

		goto finish;

	}



	tctrlr->psk_size = rc;

	rc = 0;



finish:

	spdk_memset_s(psk_configured, sizeof(psk_configured), 0, sizeof(psk_configured));