Commit 83b57c54 authored by Shuhei Matsumoto's avatar Shuhei Matsumoto Committed by Tomasz Zawadzki
Browse files

bdev/hello_world: Use spdk_bdev_open_ext() instead of spdk_bdev_open() 



This is a drop-in replacement.

Signed-off-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: I20dc836b4d17770c8164c737e5523ebbf6fb22bc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4708


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 3ac1d76a

examples/bdev/hello_world/hello_bdev.c

+17 −14
Original line number Diff line number Diff line
@@ -184,6 +184,13 @@ hello_write(void *arg) 
	}

}



static void

hello_bdev_event_cb(enum spdk_bdev_event_type type, struct spdk_bdev *bdev,

		    void *event_ctx)

{

	SPDK_NOTICELOG("Unsupported bdev event: type %d\n", type);

}



/*

 * Our initial event that kicks off everything from main().

 */
@@ -199,29 +206,25 @@ hello_start(void *arg1) 
	SPDK_NOTICELOG("Successfully started the application\n");



	/*

	 * Get the bdev. There can be many bdevs configured, but this

	 * application will only use the one input by the user at runtime so

	 * we get it via its name.

	 */

	hello_context->bdev = spdk_bdev_get_by_name(hello_context->bdev_name);

	if (hello_context->bdev == NULL) {

		SPDK_ERRLOG("Could not find the bdev: %s\n", hello_context->bdev_name);

		spdk_app_stop(-1);

		return;

	}



	/*

	 * Open the bdev by calling spdk_bdev_open()

	 * There can be many bdevs configured, but this application will only use

	 * the one input by the user at runtime.

	 *

	 * Open the bdev by calling spdk_bdev_open_ext() with its name.

	 * The function will return a descriptor

	 */

	SPDK_NOTICELOG("Opening the bdev %s\n", hello_context->bdev_name);

	rc = spdk_bdev_open(hello_context->bdev, true, NULL, NULL, &hello_context->bdev_desc);

	rc = spdk_bdev_open_ext(hello_context->bdev_name, true, hello_bdev_event_cb, NULL,

				&hello_context->bdev_desc);

	if (rc) {

		SPDK_ERRLOG("Could not open bdev: %s\n", hello_context->bdev_name);

		spdk_app_stop(-1);

		return;

	}



	/* A bdev pointer is valid while the bdev is opened. */

	hello_context->bdev = spdk_bdev_desc_get_bdev(hello_context->bdev_desc);





	SPDK_NOTICELOG("Opening io channel\n");

	/* Open I/O channel */

	hello_context->bdev_io_channel = spdk_bdev_get_io_channel(hello_context->bdev_desc);