Commit 8337cc2d authored Oct 10, 2018 by Lance Hartmann Committed by Jim Harris Oct 11, 2018

env_dpdk: Eliminate unneeded start group ld opt



The ENV_LINKER_ARGS was employing both the linker --[start|end]-group
and --[whole|no-whole]-archive options around the DPDK_LIBs. With
the use of whole/no-whole, the start/end bracketing is unnecessary.

Change-Id: I97a2ac22df8c6b48ba674b9b292f5eea01823901
Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com>
Reviewed-on: https://review.gerrithub.io/428737


Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>

parent f4cb6c90

lib/env_dpdk/env.mk

+1 −1

Original line number	Diff line number	Diff line
		@@ -96,7 +96,7 @@ ENV_CFLAGS = $(DPDK_INC) -Wno-deprecated-declarations
		ENV_CXXFLAGS = $(ENV_CFLAGS)
		ENV_DPDK_FILE = $(call spdk_lib_list_to_files,env_dpdk)
		ENV_LIBS = $(ENV_DPDK_FILE) $(DPDK_LIB)
		ENV_LINKER_ARGS = $(ENV_DPDK_FILE) -Wl,--start-group -Wl,--whole-archive $(DPDK_LIB) -Wl,--end-group -Wl,--no-whole-archive
		ENV_LINKER_ARGS = $(ENV_DPDK_FILE) -Wl,--whole-archive $(DPDK_LIB) -Wl,--no-whole-archive

		ifneq (,$(wildcard $(DPDK_INC_DIR)/rte_config.h))
		ifneq (,$(shell grep -e "define RTE_LIBRTE_VHOST_NUMA 1" -e "define RTE_EAL_NUMA_AWARE_HUGEPAGES 1" $(DPDK_INC_DIR)/rte_config.h))