Commit 82338848 authored by Jim Harris's avatar Jim Harris Committed by Changpeng Liu
Browse files

nvme/compliance: add test case for PROPERTY_GET 



This is a reproduction vehicle for issue #2218.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: Ib52d959436550461cf787b918b8870218536a4c1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10009


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
parent 8f11535d

test/nvme/compliance/nvme_compliance.c

+35 −0
Original line number Diff line number Diff line
@@ -502,6 +502,40 @@ delete_io_cq(void) 
	spdk_nvme_detach(ctrlr);

}



static void

property_get(void)

{

	struct spdk_nvme_ctrlr *ctrlr;

	struct spdk_nvmf_fabric_prop_set_cmd cmd;

	struct status s;

	int rc;



	SPDK_CU_ASSERT_FATAL(spdk_nvme_transport_id_parse(&g_trid, g_trid_str) == 0);

	ctrlr = spdk_nvme_connect(&g_trid, NULL, 0);

	SPDK_CU_ASSERT_FATAL(ctrlr);



	memset(&cmd, 0, sizeof(cmd));

	cmd.opcode = SPDK_NVME_OPC_FABRIC;

	cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_PROPERTY_GET;

	cmd.ofst = 0; /* CAP */

	cmd.attrib.size = SPDK_NVMF_PROP_SIZE_8;



	s.done = false;

	rc = spdk_nvme_ctrlr_cmd_admin_raw(ctrlr, (struct spdk_nvme_cmd *)&cmd, NULL, 0, test_cb, &s);

	CU_ASSERT(rc == 0);



	wait_for_admin_completion(&s, ctrlr);



	/* Non-fabrics controllers should fail an SPDK_NVME_OPC_FABRIC. */

	if (spdk_nvme_ctrlr_is_fabrics(ctrlr)) {

		CU_ASSERT(s.cpl.status.sc == SPDK_NVME_SC_SUCCESS);

	} else {

		CU_ASSERT(s.cpl.status.sc == SPDK_NVME_SC_INVALID_OPCODE);

	}



	spdk_nvme_detach(ctrlr);

}



static int

parse_args(int argc, char **argv, struct spdk_env_opts *opts)

{
@@ -776,6 +810,7 @@ int main(int argc, char **argv) 
	CU_ADD_TEST(suite, delete_io_cq);

	CU_ADD_TEST(suite, get_features);

	CU_ADD_TEST(suite, set_features_number_of_queues);

	CU_ADD_TEST(suite, property_get);



	CU_basic_set_mode(CU_BRM_VERBOSE);

	CU_basic_run_tests();