Commit 81a3b8a5 authored by Jim Harris's avatar Jim Harris Committed by Tomasz Zawadzki
Browse files

nvmf: make nacwu 0-based 



spdk_bdev_get_acwu() is a 1-based number, so we need
to subtract 1 from it before assigning the value to
nsdata->nacwu.

Signed-off-by: default avatarJim Harris <james.r.harris@intel.com>
Change-Id: I32708b28a35670cba6013a48b79389fa48226285
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12399


Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarTomasz Zawadzki <tomasz.zawadzki@intel.com>
parent 164ab112

lib/nvmf/ctrlr_bdev.c

+1 −1
Original line number Diff line number Diff line
@@ -150,7 +150,7 @@ nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *n 
	nsdata->nuse = num_blocks;

	nsdata->nlbaf = 0;

	nsdata->flbas.format = 0;

	nsdata->nacwu = spdk_bdev_get_acwu(bdev);

	nsdata->nacwu = spdk_bdev_get_acwu(bdev) - 1; /* nacwu is 0-based */

	if (!dif_insert_or_strip) {

		nsdata->lbaf[0].ms = spdk_bdev_get_md_size(bdev);

		nsdata->lbaf[0].lbads = spdk_u32log2(spdk_bdev_get_block_size(bdev));

test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c

+1 −1
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ test_nvmf_bdev_ctrlr_identify_ns(void) 
	memcpy(ns.opts.eui64, eui64, 8);



	bdev.blockcnt = 10;

	bdev.acwu = 0;

	bdev.acwu = 1;

	bdev.md_len = 512;

	bdev.dif_type = SPDK_DIF_TYPE1;

	bdev.blocklen = 4096;