Commit 814cd258 authored by Changpeng Liu's avatar Changpeng Liu Committed by Tomasz Zawadzki
Browse files

nvmf: optimize log level for unsupported feature IDs and invalid property offset 



Since we are using NVMf fabric library to emulate a PCIe based SSD via
vfio-user target, so there maybe some commands that are related with
PCIe SSD only, such as set/get features with interrupt coalescing
and Interrupt Mask Set/Interrupt Mask Clear registers.  Even the
NVMf library doesn't support that, it is not a fatal error to Host
NVMe driver, so here we use the info log instead of error log for
this case so that to avoid noise logs.

Fix #2036.

Change-Id: I8283bcde5779080835d6ab827dbd852b3816176f
Signed-off-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8766


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatar <dongx.yi@intel.com>
Reviewed-by: default avatarZiye Yang <ziye.yang@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
parent 3eed8456

lib/nvmf/ctrlr.c

+2 −2
Original line number Diff line number Diff line
@@ -1287,7 +1287,7 @@ nvmf_property_set(struct spdk_nvmf_request *req) 


	prop = find_prop(cmd->ofst, size);

	if (prop == NULL || prop->set_cb == NULL) {

		SPDK_ERRLOG("Invalid offset 0x%x\n", cmd->ofst);

		SPDK_INFOLOG(nvmf, "Invalid offset 0x%x\n", cmd->ofst);

		response->status.sct = SPDK_NVME_SCT_COMMAND_SPECIFIC;

		response->status.sc = SPDK_NVMF_FABRIC_SC_INVALID_PARAM;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;
@@ -2918,7 +2918,7 @@ nvmf_ctrlr_set_features(struct spdk_nvmf_request *req) 
	case SPDK_NVME_FEAT_HOST_BEHAVIOR_SUPPORT:

		return nvmf_ctrlr_set_features_host_behavior_support(req);

	default:

		SPDK_ERRLOG("Set Features command with unsupported feature ID 0x%02x\n", feature);

		SPDK_INFOLOG(nvmf, "Set Features command with unsupported feature ID 0x%02x\n", feature);

		response->status.sc = SPDK_NVME_SC_INVALID_FIELD;

		return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE;

	}