Commit 81062f60 authored by Daniel Verkamp's avatar Daniel Verkamp Committed by Ben Walker
Browse files

nvmf: disallow I/O connect on Discovery controller 



Discovery controllers only have an admin queue.

Change-Id: I5d5a018a7df40164838a4b03f7f106a96db7e33b
Signed-off-by: default avatarDaniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/374736


Tested-by: default avatarSPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 5b4b66ba

lib/nvmf/ctrlr.c

+6 −0
Original line number Diff line number Diff line
@@ -282,6 +282,12 @@ spdk_nvmf_ctrlr_connect(struct spdk_nvmf_qpair *qpair, 
			return;

		}



		if (ctrlr->subsys->subtype == SPDK_NVMF_SUBTYPE_DISCOVERY) {

			SPDK_ERRLOG("I/O connect not allowed on discovery controller\n");

			INVALID_CONNECT_CMD(qid);

			return;

		}



		if (!ctrlr->vcprop.cc.bits.en) {

			SPDK_ERRLOG("Got I/O connect before ctrlr was enabled\n");

			INVALID_CONNECT_CMD(qid);