Commit 80e25681 authored by Konrad Sztyber's avatar Konrad Sztyber
Browse files

accel/dpdk_compressdev: use errnos to complete tasks 



rte_compressdev uses rte_comp_op_status to return status, while accel
expects negative errno, so translate it before completing an accel task.

Signed-off-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25007

 (master)

(cherry picked from commit 72c6ad5f)
Change-Id: I4caa5000a275a4ed3e0dbbe0d64f2840017ff4fc
Signed-off-by: default avatarMarek Chomnicki <marek.chomnicki@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/25020


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarKonrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
parent 4b88d742

module/accel/dpdk_compressdev/accel_dpdk_compressdev.c

+2 −0
Original line number Diff line number Diff line
@@ -586,8 +586,10 @@ comp_dev_poller(void *args) 
			if (task->output_size != NULL) {

				*task->output_size = deq_ops[i]->produced;

			}

			status = 0;

		} else {

			SPDK_NOTICELOG("Deque status %u\n", status);

			status = -EIO;

		}



		spdk_accel_task_complete(task, status);

test/unit/lib/accel/dpdk_compressdev.c/accel_dpdk_compressdev_ut.c

+2 −2
Original line number Diff line number Diff line
@@ -889,7 +889,7 @@ test_poller(void) 
	/* Error from dequeue, nothing needing to be resubmitted.

	 */

	ut_rte_compressdev_dequeue_burst = 1;

	ut_expected_task_status = RTE_COMP_OP_STATUS_NOT_PROCESSED;

	ut_expected_task_status = -EIO;

	/* setup what we want dequeue to return for the op */

	*RTE_MBUF_DYNFIELD(g_comp_op[0].m_src, g_mbuf_offset, uint64_t *) = (uint64_t)&task[0];

	g_comp_op[0].produced = 1;
@@ -899,7 +899,7 @@ test_poller(void) 
	rc = comp_dev_poller((void *)g_comp_ch);

	CU_ASSERT(STAILQ_EMPTY(&g_comp_ch->queued_tasks) == true);

	CU_ASSERT(rc == SPDK_POLLER_BUSY);

	ut_expected_task_status = RTE_COMP_OP_STATUS_SUCCESS;

	ut_expected_task_status = 0;



	/* Success from dequeue, 2 ops. nothing needing to be resubmitted.

	 */