Commit 7ffc8833 authored by Ben Walker's avatar Ben Walker Committed by Jim Harris
Browse files

examples/nvme/hello_world: Iterate only active namespaces 



Avoid registering inactive namespaces in the example. They can't be used
for I/O.

Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Change-Id: I404ca48666b566fd3248a3f56b25ea6509fa8d38
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10099


Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 6ccc8c1a

examples/nvme/hello_world/hello_world.c

+3 −4
Original line number Diff line number Diff line
@@ -321,7 +321,7 @@ static void 
attach_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid,

	  struct spdk_nvme_ctrlr *ctrlr, const struct spdk_nvme_ctrlr_opts *opts)

{

	int nsid, num_ns;

	int nsid;

	struct ctrlr_entry *entry;

	struct spdk_nvme_ns *ns;

	const struct spdk_nvme_ctrlr_data *cdata;
@@ -357,9 +357,8 @@ attach_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid, 
	 *

	 * Note that in NVMe, namespace IDs start at 1, not 0.

	 */

	num_ns = spdk_nvme_ctrlr_get_num_ns(ctrlr);

	printf("Using controller %s with %d namespaces.\n", entry->name, num_ns);

	for (nsid = 1; nsid <= num_ns; nsid++) {

	for (nsid = spdk_nvme_ctrlr_get_first_active_ns(ctrlr); nsid != 0;

	     nsid = spdk_nvme_ctrlr_get_next_active_ns(ctrlr, nsid)) {

		ns = spdk_nvme_ctrlr_get_ns(ctrlr, nsid);

		if (ns == NULL) {

			continue;