Commit 7dcc2507 authored by Liu Xiaodong's avatar Liu Xiaodong Committed by Tomasz Zawadzki
Browse files

bdev/lvol: asserting lvol ptr before dereference 



Klocwork filtered it out that there is a dereference
of pointer 'lvol' before its NULL check.

Change-Id: I83a026e8762d1e004cf1a351585f48fb1e24ae41
Signed-off-by: default avatarLiu Xiaodong <xiaodong.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9208


Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarGangCao <gang.cao@intel.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
parent 3220a053

module/bdev/lvol/vbdev_lvol.c

+2 −1
Original line number Diff line number Diff line
@@ -588,9 +588,10 @@ static int 
vbdev_lvol_unregister(void *ctx)

{

	struct spdk_lvol *lvol = ctx;

	struct lvol_bdev *lvol_bdev = SPDK_CONTAINEROF(lvol->bdev, struct lvol_bdev, bdev);

	struct lvol_bdev *lvol_bdev;



	assert(lvol != NULL);

	lvol_bdev = SPDK_CONTAINEROF(lvol->bdev, struct lvol_bdev, bdev);



	spdk_bdev_alias_del_all(lvol->bdev);

	spdk_lvol_close(lvol, _vbdev_lvol_unregister_cb, lvol_bdev);