Commit 7dbe9cfa authored by Ben Walker's avatar Ben Walker Committed by Tomasz Zawadzki
Browse files

bdev/nvme: When detecing multipath, only compare active namespaces 



Calling spdk_nvme_ns_get_data(ns) on an inactive namespace will crash.

Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Change-Id: Ib8cfa84e785a4a04dc3b1826c700a22eeec51e3c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5013


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent e7cbcec3

module/bdev/nvme/bdev_nvme.c

+4 −0
Original line number Diff line number Diff line
@@ -1784,6 +1784,10 @@ bdev_nvme_add_trid(struct nvme_bdev_ctrlr *nvme_bdev_ctrlr, struct spdk_nvme_tra 
	}



	for (i = 1; i <= nvme_bdev_ctrlr->num_ns; i++) {

		if (!spdk_nvme_ctrlr_is_active_ns(nvme_bdev_ctrlr->ctrlr, i)) {

			continue;

		}



		ns = spdk_nvme_ctrlr_get_ns(nvme_bdev_ctrlr->ctrlr, i);

		new_ns = spdk_nvme_ctrlr_get_ns(new_ctrlr, i);

		assert(ns != NULL);