Commit 7dbe0e7c authored by Ben Walker's avatar Ben Walker Committed by Tomasz Zawadzki
Browse files

nvme: Remove nvme_transport_get_ctrlr_registers 



Wasn't used.

Change-Id: I9812e24540f6d86f47d39091ea5fd9b7880b4413
Signed-off-by: default avatarBen Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/735


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
parent 486471b1

include/spdk/nvme.h

+0 −2
Original line number Diff line number Diff line
@@ -2880,8 +2880,6 @@ struct spdk_nvme_transport_ops { 


	int (*ctrlr_connect_qpair)(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_qpair *qpair);



	volatile struct spdk_nvme_registers *(*ctrlr_get_registers)(struct spdk_nvme_ctrlr *ctrlr);



	void (*ctrlr_disconnect_qpair)(struct spdk_nvme_ctrlr *ctrlr, struct spdk_nvme_qpair *qpair);



	void (*qpair_abort_reqs)(struct spdk_nvme_qpair *qpair, uint32_t dnr);

lib/nvme/nvme_ctrlr.c

+0 −6
Original line number Diff line number Diff line
@@ -86,12 +86,6 @@ nvme_ctrlr_get_cmbsz(struct spdk_nvme_ctrlr *ctrlr, union spdk_nvme_cmbsz_regist 
					      &cmbsz->raw);

}



volatile struct spdk_nvme_registers *

spdk_nvme_ctrlr_get_registers(struct spdk_nvme_ctrlr *ctrlr)

{

	return nvme_transport_ctrlr_get_registers(ctrlr);

}



void

spdk_nvme_ctrlr_get_default_ctrlr_opts(struct spdk_nvme_ctrlr_opts *opts, size_t opts_size)

{

lib/nvme/nvme_internal.h

+0 −2
Original line number Diff line number Diff line
@@ -1139,8 +1139,6 @@ struct spdk_nvme_qpair *nvme_transport_ctrlr_create_io_qpair(struct spdk_nvme_ct 
		uint16_t qid, const struct spdk_nvme_io_qpair_opts *opts);

void *nvme_transport_ctrlr_alloc_cmb_io_buffer(struct spdk_nvme_ctrlr *ctrlr, size_t size);

int nvme_transport_ctrlr_free_cmb_io_buffer(struct spdk_nvme_ctrlr *ctrlr, void *buf, size_t size);

volatile struct spdk_nvme_registers *nvme_transport_ctrlr_get_registers(

	struct spdk_nvme_ctrlr *ctrlr);

int nvme_transport_ctrlr_delete_io_qpair(struct spdk_nvme_ctrlr *ctrlr,

		struct spdk_nvme_qpair *qpair);

int nvme_transport_ctrlr_connect_qpair(struct spdk_nvme_ctrlr *ctrlr,

lib/nvme/nvme_pcie.c

+0 −9
Original line number Diff line number Diff line
@@ -600,14 +600,6 @@ nvme_pcie_ctrlr_alloc_cmb(struct spdk_nvme_ctrlr *ctrlr, uint64_t length, uint64 
	return 0;

}



static volatile struct spdk_nvme_registers *

nvme_pcie_ctrlr_get_registers(struct spdk_nvme_ctrlr *ctrlr)

{

	struct nvme_pcie_ctrlr *pctrlr = nvme_pcie_ctrlr(ctrlr);



	return pctrlr->regs;

}



static void *

nvme_pcie_ctrlr_alloc_cmb_io_buffer(struct spdk_nvme_ctrlr *ctrlr, size_t size)

{
@@ -2330,7 +2322,6 @@ const struct spdk_nvme_transport_ops pcie_ops = { 
	.ctrlr_set_reg_8 = nvme_pcie_ctrlr_set_reg_8,

	.ctrlr_get_reg_4 = nvme_pcie_ctrlr_get_reg_4,

	.ctrlr_get_reg_8 = nvme_pcie_ctrlr_get_reg_8,

	.ctrlr_get_registers = nvme_pcie_ctrlr_get_registers,



	.ctrlr_get_max_xfer_size = nvme_pcie_ctrlr_get_max_xfer_size,

	.ctrlr_get_max_sges = nvme_pcie_ctrlr_get_max_sges,

lib/nvme/nvme_rdma.c

+0 −7
Original line number Diff line number Diff line
@@ -2097,12 +2097,6 @@ nvme_rdma_ctrlr_get_max_sges(struct spdk_nvme_ctrlr *ctrlr) 
	return rctrlr->max_sge;

}



static volatile struct spdk_nvme_registers *

nvme_rdma_ctrlr_get_registers(struct spdk_nvme_ctrlr *ctrlr)

{

	return NULL;

}



static void *

nvme_rdma_ctrlr_alloc_cmb_io_buffer(struct spdk_nvme_ctrlr *ctrlr, size_t size)

{
@@ -2156,7 +2150,6 @@ const struct spdk_nvme_transport_ops rdma_ops = { 
	.ctrlr_set_reg_8 = nvme_fabric_ctrlr_set_reg_8,

	.ctrlr_get_reg_4 = nvme_fabric_ctrlr_get_reg_4,

	.ctrlr_get_reg_8 = nvme_fabric_ctrlr_get_reg_8,

	.ctrlr_get_registers = nvme_rdma_ctrlr_get_registers,



	.ctrlr_get_max_xfer_size = nvme_rdma_ctrlr_get_max_xfer_size,

	.ctrlr_get_max_sges = nvme_rdma_ctrlr_get_max_sges,