Commit 7d7b44f2 authored by Seth Howell's avatar Seth Howell Committed by Jim Harris
Browse files

rdma: decrement descriptor before checking SEND_WITH_INVAL 



We were incrementing over the end of the descriptor list and assigning
undefined values to the rsp opcode in SEND_WITH_INVAL case. We were only
hitting this error when mixing sgl and inline requests in the same
workload. We were just by chance hitting a four bit value that was set
to all 1s from the in capsule data from the last request.

Change-Id: Ied06356f3d22fa34a2cd869dfad6bdca8720791d
Signed-off-by: default avatarSeth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450873


Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: default avatarShuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: default avatarJim Harris <james.r.harris@intel.com>
parent 3f2553a3

lib/nvmf/rdma.c

+2 −0
Original line number Diff line number Diff line
@@ -1629,6 +1629,8 @@ nvmf_rdma_request_fill_iovs_multi_sgl(struct spdk_nvmf_rdma_transport *rtranspor 
	}



#ifdef SPDK_CONFIG_RDMA_SEND_WITH_INVAL

	/* Go back to the last descriptor in the list. */

	desc--;

	if ((device->attr.device_cap_flags & IBV_DEVICE_MEM_MGT_EXTENSIONS) != 0) {

		if (desc->keyed.subtype == SPDK_NVME_SGL_SUBTYPE_INVALIDATE_KEY) {

			rdma_req->rsp.wr.opcode = IBV_WR_SEND_WITH_INV;