Commit 7cfb12f4 authored by GangCao's avatar GangCao Committed by Tomasz Zawadzki
Browse files

Bdev/Lvol: check base bdev's md before examining 



To fix issue #2514

Change-Id: If507382202e729f5934a354e2515a035ad5aeb0c
Signed-off-by: default avatarGangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12750


Reviewed-by: default avatarChangpeng Liu <changpeng.liu@intel.com>
Reviewed-by: default avatarAleksey Marchuk <alexeymar@nvidia.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: default avatarSPDK CI Jenkins <sys_sgci@intel.com>
parent 0f3f107d

module/bdev/lvol/vbdev_lvol.c

+7 −0
Original line number Diff line number Diff line
@@ -1441,6 +1441,13 @@ vbdev_lvs_examine(struct spdk_bdev *bdev) 
	struct spdk_lvs_with_handle_req *req;

	int rc;



	if (spdk_bdev_get_md_size(bdev) != 0) {

		SPDK_INFOLOG(vbdev_lvol, "Cannot create bs dev on %s\n which is formatted with metadata",

			     bdev->name);

		spdk_bdev_module_examine_done(&g_lvol_if);

		return;

	}



	req = calloc(1, sizeof(*req));

	if (req == NULL) {

		spdk_bdev_module_examine_done(&g_lvol_if);

test/unit/lib/bdev/vbdev_lvol.c/vbdev_lvol_ut.c

+6 −0
Original line number Diff line number Diff line
@@ -73,6 +73,12 @@ spdk_bdev_get_aliases(const struct spdk_bdev *bdev) 
	return &bdev->aliases;

}



uint32_t

spdk_bdev_get_md_size(const struct spdk_bdev *bdev)

{

	return bdev->md_len;

}



int

spdk_bdev_alias_add(struct spdk_bdev *bdev, const char *alias)

{